Re: [Plib-devel] ssgVtxArray bug(s) ?

[Steve B. <sjb...@ai...>]

Dave McClurg wrote:
> 
> Steve wrote:
> > I was looking in the ssgVtxTable class code and spotted a bug ...
> yikes!
> 
> <snip>
> > I'm suprised that this wouldn't have shown up MUCH earlier.
> > Do I have a crossed wire here - or is this really a bug?
> >
> i think these are really bugs. :(  Mark?
> 
> > Is anyone actually using ssgVtxArray?
> >
> i'm using it heavily since i modified the ssgLoadASE loader to use
> ssgVtxArray for all leaves.  ASE models are already in indexed form.  i
> noticed a 50% frame rate boost on my geforce 256.  thanks Mark!

Yep - that's known to be "A Good Thing" for GeForce.  The other thing
that we need to change for efficiency is to use (IIRC) short's for
normals and char's for colours.   I think we can hack ssgVtxArray to
do that without too many problems.

Once Linux OpenGL implementations start to support the OpenGL ABI, we
can also use the Compiled Vertex Array extension and get still more
speedup.

> i pre-light most of my models and don't use normals.  also, i'm not
> transforming the model yet, just rotating the camera around the model.

The 'transform' member function isn't used for models that you move around
in realtime - it's used for the 'ssgFlatten' optimisation that multiplies
out ssgTransform nodes to cut down on redundant matrix multiplies during
realtime.  But if you aren't using normals, you certainly won't see the
*ORIGINAL* bug - I havn't yet checked ALL the places where the index-array
problem bites.

> that's probably why i haven't seen these bugs yet.  i fixed a few other bugs
> which occured when i passed NULL for the normal array.
> 
> please go ahead and make the fixes if you would be so kind or let me know if
> you don't have time and i'll give it a try.

OK - I'll patch the ones I can recognise.

-- 
Steve Baker   HomeEmail: <sjb...@ai...>
              WorkEmail: <sj...@li...>
              HomePage : http://web2.airmail.net/sjbaker1
              Projects : http://plib.sourceforge.net
                         http://tuxaqfh.sourceforge.net
                         http://tuxkart.sourceforge.net
                         http://prettypoly.sourceforge.net