Re: [Plib-devel] [PATCH] puAuxLargeInput: fix selection bug, make not needed sliders disappear
Brought to you by:
sjbaker
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-20 20:10:44
|
Melchior, As I am making the changes, I find that the default value of the puAuxLargeInput text is being changed from a "\n" to an empty string. In the original large input, I required all lines to end with a carriage return and in some cases the application program depended on it being there. Is this a deliberate change? John F. Fay Technical Fellow Jacobs Technology TEAS Group 850-883-1294 -----Original Message----- From: Melchior FRANZ [mailto:mf...@us...] Sent: Tuesday, January 20, 2009 1:31 PM To: pli...@li... Subject: Re: [Plib-devel] [PATCH] puAuxLargeInput: fix selection bug,make not needed sliders disappear * Fay, John F Dr CTR USAF AFMC 46 SK -- Tuesday 20 January 2009: > Is it all one change or can it be broken up into pieces? It's two things: a minor fix (which is only two lines, so factoring it out doesn't make a lot of sense), and the rest is one feature (with a bit of cleanup and abstraction). The feature is "autohiding sliders". They are hiding, if they aren't necessary, because the lines are short enough for the width, and few enough for the box height. This doesn't only look nicer, it also frees precious space and is kind of a standard in modern GUIs. With shorter response times I could make smaller patches, but if getting one patch in takes five days, then this is impractical. I can do a lot in five days, and there is too much overlapping to write subsequent patches. What if you make changes to the first? Then all others are likely no longer applicable. I know, of course, that you are the only left-over committer (just as I'm the only left-over pui/puAux developer :-), and I'm happy to get something reviewed and committed at all. m. PS: Here's my testing setup in FlightGear: http://members.aon.at/mfranz/fgfs-plib.jpg [98.3 kB] The "windows" are all resizable, so autohiding and line wrapping are easy to observe. ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ plib-devel mailing list pli...@li... https://lists.sourceforge.net/lists/listinfo/plib-devel |