Re: [Plib-devel] patch for compiling on Solaris 10

[Bert D. <dri...@pl...>]

On Thu, 14 Dec 2006, Fay John F Dr CTR USAF AFSEO/SK wrote:

> 	It appears from the message below that the "configure" test for
> "socklen_t" fails on Sun Studio 11 compilers because they do not support
> "-Wall".  I see three options:
>
> (1)  Drop the "-Wall" flag.  I do not like this option because I like the
> compiler to warn me when things are iffy.
>
> (2)  Quit checking for "socklen_t" in the "configure" step.  Vijay Kumar,
> who flagged the error, supports this option.  The reasoning is that
> "socklen_t" is pretty much universal by now.
>
> (3)  Make the "-Wall" flag system-dependent and don't use it Sun Studio 11
> compilers.  Is such a thing possible?

My two cents: dropping the check for socklen_t is not the desirable 
solution. It was obviously put there for a reason, and PLIB is used on 
platforms some of us haven't even heard of. So unless someone recalls 
what platforms were unbroken by adding that check, I would not call 
dropping it a safe change.

Obviously, when a compiler barfs on -Wall, we should not add -Wall to 
the compiler options. There is autoconf magic to check for GCC and set 
-Wall as required (I seem to recall that the AC_PROG_CPP does the 
appropriate magic).