Re: [Plib-devel] release candidate awaits your testing.

[<coz...@gm...>]

> > * The next one is meant to work together with the fullscreen patch for
> > X11 by Hans de Goede, but patching manually isn't difficult and
> > worked. It fixes some issues with auto-repeat in pw:
> >
> > https://lists.berlios.de/pipermail/supertuxkart-devel/2006-October/000232.html
> >
>
> I don't understand this patch.
> I guess these lines are the important ones:
>
> +  if ( haveFocus && !autoRepeat )
> +    XAutoRepeatOn ( currDisplay ) ;
> +
>
> Why the reversed logic?
> !autoRepeat .... XAutoRepeatOn ???
>
> I would have expected the func XAutoRepeatOff(display)
> What's going on?

I didn't really checked the sources when I first checked the patch,
but it mostly worked. It is a bit confusing...

if you mean the part just under the case focusOut: , then it means
that if pw disabled X's auto repeat, when you lose the focus you
should re-enable it for other applications. In the other case is
called in pwCleanup(), so here it is meant to re-enable auto repeat
when you close the window.

A better solution would be not to use X's auto repeat at all, but
plib's previous implementation, which didn't used X's auto repeat, was
pretty broken anyways, keypresses were lost.

-Coz