[Plib-devel] Re: [BUG] & non-virtual methods (that should be virtual)

[Melchior F. <mf...@us...>]

* Bram Stolk -- Saturday 25 March 2006 01:04:
> Melchior FRANZ wrote:
> But I guess it goes unnoticed, because nobody seems to use
> these special sliders. E.g., they are not used in ./examples,
> and google shows little reference too them.

True. When there's no way to see how they look and what they do, then
many people don't bother to try them out. The puaList class can't have
been used much either. It caused a linking error. Or was it just
because it was so broken.  :-)



> Your suggestion sounds right, but the funcs already made their way
> into flightgear source, according to google. 

That's not a problem. I am FlightGear's (inofficial) GUI maintainer,
and it's our own puList class that became puaList. We are still using
our own copy, but I'd like to switch to puaList after the next release.
We don't rely on those ugly getList*Value() methods. You can rip them
out and make the getters virtual. 



> So maybe make getXxxValue() 
> virtual, override, and keep the workaround with a warning mesg?

No, just remove them! But the getters need to be made virtual in pu.h!



> I want to get rid of those destructors that should have been
> virtual,but are not:

Don't sound familiar. No side effects on FlightGear.

m.