[Plib-devel] Re: [PATCH] puListBox: don't use hard-coded colo rs

[Melchior F. <mf...@us...>]

* Fay John F Contr AAC/WMG -- Thursday 14 July 2005 19:51:
> I fixed the "puListBox" color and mentioned that elsewhere.

Yes, I saw it. Thanks.


 
> I took a quick look at the "puComboBox" code and didn't see
> any colors mentioned, so I wasn't sure where to go with it.  Perhaps we
> should simply change the "setColour" functions to flow the colors down to
> the subwidgets in the parent widget.

Yes, that's the theory: just let the children inherit the widget's colors.
But here's a problem: we only have 6, and all of them are used already(?).

- PUCOL_FOREGROUND, PUCOL_BACKGROUND, PUCOL_HIGHLIGHT for widget color plus
     bevel frame color (e.g. the tiny puSelectBox up/down buttons)
 
- PUCOL_LEGEND, and PUCOL_LABEL for what they say they are  :-)
- PUCOL_MISC for the the cursor color (puComboBox)


Nothing left that we could use for the puInput area. One possible way
would be to introduce another color, for example one that is always used
for input fields (puInput, puComboBox, puSelectBox). Another would be to
add an extra color setter for these puObjects. The latter is quite ugly.
The former is probably not acceptable, either. (Despite the fact that
plib is prepared for another color ... PUCOL_MAX.)

And that's why I didn't submit a patch for this. Seems to be an
architecture question, not just a simple bugfix.

m.