Re: [Plib-devel] Portability; Was: Minor Issues with PLIB Release Candidate

[Frederic B. <fre...@fr...>]

Steve Baker a =E9crit :

> Martin Spott wrote:
>
>> Steve Baker wrote:
>>
>>
>>> These relatively new C++ features are always tricky - we should
>>> avoid them in software like PLIB where portability is a key feature.
>>
>>
>>
>> While you are talking about portability: Is there any significant
>> reason why the fix that is required to build PLIB on FreeBSD is being
>> silently ignored ?
>
>
> I thought all but one of the changes were in there?
>
> Certainly the fixes for the joystick library are.
>
> The only fix I'm aware of that wasn't committed was the one about
> removing glIsValidContext.   That isn't a bug in PLIB - it's a bug
> elsewhere.  You need to be complaining (or helping with a fix) in
> some other part of the system rather than breaking this library to
> cover up a bug in some other library.
>
> If glIsValidContext is broken, it's almost certainly just the first
> symptom of a BUNCH of other things that are broken that you just
> haven't noticed yet.
>
I guess Martin was writting about this one :

The patch against src/sl/slPortability.h is still missing:

--- ./src/sl/slPortability.h.orig	Sat Sep  7 17:54:59 2002
+++ ./src/sl/slPortability.h	Sat Sep  7 17:55:22 2002
@@ -74,7 +74,7 @@
 #  if defined(__linux__)
 #    include <linux/soundcard.h>
 #  elif defined(__FreeBSD__)
-#    include <machine/soundcard.h>
+#    include <sys/soundcard.h>
 #  else
     /*
       Tom thinks this file may be <sys/soundcard.h> under some




-Fred