Re: [Plib-devel] Minor Issues with PLIB Release Candidate

[Steve B. <sjb...@ai...>]

Frederic Bouvier wrote:
> Bram Stolk a =E9crit :
>=20
>> Fay John F Contr AAC/WMG wrote:
>>
>>>     - ssgSaveIV.cxx:100,233,240,246,255,270 - dynamic-cast used on
>>> polymorphic type with "/GR-"; behavior is unpredictable
>>
>>
>>
>> I assume that "/GR-" is a flag for your win32 compiler?
>> What does this flag do?
>> Is removing this flag an option?
>>
>> If not, using isAKindOf() coupled with a static_cast<>() should
>> be a possible replacement of the dynamic cast.
>>
>> I find it strange that win32 is not able to cope with this.
>> I would guess that *all* base classes that have derived
>> classes are polymorphic. That means dynamic_cast cant be used
>> at all in your setup.
>=20
>=20
> /GR- is the default option, when you don't specify it in your MSVC=20
> project. Somebody should edit ssg.dsp to add the /GR option ( preferabl=
y=20
> in the IDE, not in vi ). This flag enable C++ RTTI and it is needed=20
> because this file use dynamic_cast<>. As rtti introduce some penalty,=20
> the flag is not on by default.

It's easier (and faster) to remove the need.

I've just committed a version of ssgSaveIV that doesn't use dynamic_cast.=


---------------------------- Steve Baker -------------------------
HomeEmail: <sjb...@ai...>    WorkEmail: <sj...@li...>
HomePage : http://www.sjbaker.org
Projects : http://plib.sf.net    http://tuxaqfh.sf.net
            http://tuxkart.sf.net http://prettypoly.sf.net
-----BEGIN GEEK CODE BLOCK-----
GCS d-- s:+ a+ C++++$ UL+++$ P--- L++++$ E--- W+++ N o+ K? w--- !O M-
V-- PS++ PE- Y-- PGP-- t+ 5 X R+++ tv b++ DI++ D G+ e++ h--(-) r+++ y++++=

-----END GEEK CODE BLOCK-----