Re: [Plib-devel] Minor Issues with PLIB Release Candidate

[Steve B. <sjb...@ai...>]

Fay John F Contr AAC/WMG wrote:
> Gentlemen,
> 
>         I'm compiling the PLIB release candidate and also comparing the 
> code with my personal version.  There are some points I'd like to 
> raise.  It is too bad that I waited this long before looking at it...

It's not too late.  I promised the FGFS guys a release tomorrow *if*
nothing fatal came up.  We can probably delay a day or two to fix
these things.

If need be, we can always do another release in a week or two, remember:
Version numbers are cheap!

> (1) There are some compiler warnings under MSVC:
>         - ssgLoadAC.cxx:60 - truncation from const double to float
>         - ssgLoadMDL.cxx:390 - conversion from double to float
>         - ssgSaveIV.cxx:100,233,240,246,255,270 - dynamic-cast used on 
> polymorphic type with "/GR-"; behavior is unpredictable

I can live with those for now.

> (2) "puAux" is missing a whole lot of changes that I have made in using 
> the library.  Some "puAux" widgets refer to deprecated PUI widgets, for 
> example, and some "puaComboBox" behavior fixes that I have made haven't 
> found their way in yet.  Another change, which allows the user to 
> activate the widgets with some mouse button other than the left button, 
> also aren't there yet.

Again, those are nice things to have - but not essential to make a release.

> (3) There is some PUI functionality about when to deactivate the widget 
> that isn't in the release candidate.  The arbitrary mouse button change 
> mentioned in connection with "puAux" is also an issue here.  Finally, a 
> bug in "puPopupMenu" that puts the subwidgets into the same window as 
> their parent widgets has not been put in either.

It would be nice to fix that if we can.

>         Are these worth holding up the release?

They are worth holding the release for a day or two - but not for more
than that.  Dunno if you are able to do this over the weekend.  If so,
I'll hold up the release - if not - or if I don't hear from you - I'll
make the release tomorrow and we'll think in terms of making a second
release in a couple of weeks.

> I personally doubt it, 
> although I would push for fixing the compiler warnings.  Most users have 
> lived quite happily with the present PUI and "puAux" and that probably 
> won't change.  If you do decide to hold up the release, it will be at 
> least until Tuesday because I am about to go home and won't be back 
> until then.

OK.

---------------------------- Steve Baker -------------------------
HomeEmail: <sjb...@ai...>    WorkEmail: <sj...@li...>
HomePage : http://www.sjbaker.org
Projects : http://plib.sf.net    http://tuxaqfh.sf.net
            http://tuxkart.sf.net http://prettypoly.sf.net
-----BEGIN GEEK CODE BLOCK-----
GCS d-- s:+ a+ C++++$ UL+++$ P--- L++++$ E--- W+++ N o+ K? w--- !O M-
V-- PS++ PE- Y-- PGP-- t+ 5 X R+++ tv b++ DI++ D G+ e++ h--(-) r+++ y++++
-----END GEEK CODE BLOCK-----