[Plib-devel] Minor Issues with PLIB Release Candidate
Brought to you by:
sjbaker
From: Fay J. F C. AAC/W. <joh...@eg...> - 2005-01-14 22:09:12
|
Gentlemen, I'm compiling the PLIB release candidate and also comparing the code with my personal version. There are some points I'd like to raise. It is too bad that I waited this long before looking at it, but I just got back. Anyway, here's the laundry list. (1) There are some compiler warnings under MSVC: - ssgLoadAC.cxx:60 - truncation from const double to float - ssgLoadMDL.cxx:390 - conversion from double to float - ssgSaveIV.cxx:100,233,240,246,255,270 - dynamic-cast used on polymorphic type with "/GR-"; behavior is unpredictable (2) "puAux" is missing a whole lot of changes that I have made in using the library. Some "puAux" widgets refer to deprecated PUI widgets, for example, and some "puaComboBox" behavior fixes that I have made haven't found their way in yet. Another change, which allows the user to activate the widgets with some mouse button other than the left button, also aren't there yet. (3) There is some PUI functionality about when to deactivate the widget that isn't in the release candidate. The arbitrary mouse button change mentioned in connection with "puAux" is also an issue here. Finally, a bug in "puPopupMenu" that puts the subwidgets into the same window as their parent widgets has not been put in either. Are these worth holding up the release? I personally doubt it, although I would push for fixing the compiler warnings. Most users have lived quite happily with the present PUI and "puAux" and that probably won't change. If you do decide to hold up the release, it will be at least until Tuesday because I am about to go home and won't be back until then. John F. Fay joh...@eg... 850-729-6330 |