Re: [Plib-devel] A Second Look Into SSG

[Wolfram K. <w_...@rz...>]

Hi!

>(9) In the file "ssgBase.cxx" on line 41 in the function
>"ssgBase::copy_from", there is a test:  "if ( this =3D=3D src ) return =
;" with a
>comment "Avoid corrupting userdata when copying to self."  In the file
>"ssgSimpleList.cxx" starting on line 27 we find another "copy_from" =
function
>which (among other things) deletes a variable "list" and allocates a new
>one.  Do we want the code to do this even if "this =3D=3D src" or do we =
want to
>return without doing anything in this case?

I see. Adding a=20
if ( this =3D=3D src ) return;
does sound good.

>(15) In "ssgVtxTable.cxx" on line 704ff, we are in the function
>"hot_triangles".  [....]

Sounds good to me. However, I can not say how robust it is to
numerical accuracy. I suggest to only change this if someone from a
programm that uses it extensively - say FlightGear - will test the
change. BTW, I suggest in a case like this to add the derivation to
the code as a comment or at least, with a comment, list to the email
with the derivation.


Bye bye,
Wolfram.