Re: [Plib-devel] A Third Look Into SSG

[Wolfram K. <w_...@rz...>]

>	Part three.
>
>Serious Business:
>(1) In "ssgVtxArray.cxx" on line 207 an array of "long" is allocated and=
 its
>address stored in a local variable.  I do not see where it is ever =
deleted
>or its address stored somewhere permanent.  This is a memory leak.

=46ixed.

>
>Trivial:
>(2) More tabs that should be blank spaces in "ssg.h" on lines 643, =
676-679,
>689, 704, 713, 727 (maybe), 1021, 1422, 1432-1439, 1485, 1577, and 1593;=
 in
>"ssgVtxArray.cxx" on line 76 (after the "indices"?)

=46ixed the ssgVtxArray one.

>(7) In the file "ssgTween.cxx" on lines 150, 184, 192, 200, and 208, the
>variable "bsphere_is_invalid" is set to true immediately after a call to
>"dirtyBSphere".  The call includes that assignment and so the repeated
>assignment is not necessary.

=46ixed.

>Not so trivial:
>(10) On line 736 of "ssg.h" we see that a "setHandle()" function is
>deprecated.  Should we remove it, or at least give a date of deprecation=
 so
>that people will know how quickly they should move away from it?

It seems to me we have to remove setTexture as well then?
PPE uses this.

>(11) In the file "ssgVtxArray.h", on line 207 (site of the memory leak
>mentioned earlier), the variable "oldIndex2NewIndex" is defined to be a
>pointer to an array of longs.  Then on line 228 the value is =
"static_cast"
>to short. =20

Yes. Let's just leave it like that :-).


>John F. Fay
>joh...@eg...
>850-729-6330=20

Bye bye,
Wolfram.