Re: [Plib-devel] On First Looking Into Baker's SSG (with apologies to John Keats)
Brought to you by:
sjbaker
From: Wolfram K. <w_...@rz...> - 2004-09-13 11:18:42
|
=46irst of all, a big "excuse me" for my absence from this list and my slack in helping! Sorry! I am super busy right now with two jobs :-/. >In the realm of the trivial: >(3) In "ssgconf.h" on line 35, the word "and" should be "an" ("to an >#undef"). Done. >(4) Also in "ssgconf.h" on lines 42-43, I think the instruction to >"un-comment the following line" should be changed to something like = "change >the 'undef' on the following like to a 'define'." Are you sure? >In the realm of the not-so-trivial: >(6) From what I gather from "ssg.cxx", we do not have writers for the = "dof", >"md2", "strip", "mdl", or "xpl" file formats and we do not have loaders = for >the "asc" or "pov" file formats (the latter is commented out entirely). = Do >we need them? Do we want them? It would of course be nice to have leaders and writers for all formats, but it is not realistic. Also, not having a writer for a format does not make the loader any less useful and for example the asc loader was worth it's weight in gold as it is and actually is a small part of why I got my second job. >(9) In the "ssgList::removeAllEntities" function (ssgList.cxx:94), the >function removes entity 0 repeatedly until the list is empty. This is a= lot >like unpiling a stack of bricks by removing the bottom one each time; = the >"removeEntity" involves a "memmove" call each time. Why doesn't the >"removeAllEntities" function simply set "total" and "next" to zero? =20 I think that would be a bug. For example ssgKidList uses the normal=20 removeAllEntities but a specific removeEntity. If this would no longer be called, things would break. >At the >very least, we can speed up the "memmove" calls by invoking = "removeEntity" >with an argument of "total-1" instead of "0". I agree on this and have implemented the change. >John F. Fay >joh...@eg... Bye bye, Wolfram. |