RE: [Plib-devel] Olivier's js code

[LAVIGNE,ERIC <la...@uf...>]

When I submit this to cvs, I will be giving credit to Olivier as 
the author. With that in mind, I would prefer to use Olivier's 
version of the files from
http://perso.wanadoo.fr/oliver77-htm/plib/liste.htm.

I found two problems with Olivier's version: (1) Steve Baker made 
a change to jsMacOSX.cxx on Mar 18, 2004, and that change is not 
reflected in Olivier's file. (2) Most plib files have an 18 line 
copyright/license comment at the top. Olivier's jsMacOSX.cxx does 
not, and neither does the CVS version.

John Fay's version of jsMacOSX.cxx does not have either of these 
problems and is otherwise very similar to Olivier's version. I 
propose committing John Fay's version of jsMacOSX.cxx and 
Olivier's version of everything else.

I will commit the files on Saturday evening if there are no 
objections before that time.

Eric Lavigne


On Fri Aug 13 09:53:16 EDT 2004, Fay John F Contr AAC/WMG 
<joh...@eg...> wrote:

> Folks,
> 
> 	To provide more info on the compiler error, here is what I got 
> from
> Mr. Jones:
> 
> <begin quote>
> Black flag on the first lap...
> 
> jsLinuxOld.cxx: In constructor `jsJoystick::jsJoystick(int)':
> jsLinuxOld.cxx:97: error: `num_hats' undeclared (first use this
> function)
> jsLinuxOld.cxx:97: error: (Each undeclared identifier is reported 
> only
> once for
>    each function it appears in.)
> make: *** [jsLinuxOld.o] Error 1
>  (undoubtedly a simple fix, but I'll look at it after checking in 
> your
> other dozen changes. ;) )
> <end quote>
> 
> If you look at line 97 of "jsLinuxOld.cxx", you will find that 
> the variable
> "num_hats" does not appear there.  In fact, it does not appear 
> anywhere in
> the file!  So I do not think the problem was with Olivier's code.
> 
> 	I've checked Olivier's code against what I submitted and there 
> are a
> few differences, some formatting and some significant.  I can 
> forward a copy
> of what I have to any interested parties.
> 
> John F. Fay
> joh...@eg...
> 
> 
> 
> -----Original Message-----
> From: pli...@li...
> [mailto:pli...@li...]On Behalf Of 
> LAVIGNE,ERIC
> Sent: Thursday, August 12, 2004 4:47 PM
> To: pli...@li...
> Subject: [Plib-devel] Olivier's js code
> 
> 
> 
> I am willing and able to commit the files from
> http://perso.wanadoo.fr/oliver77-htm/plib/liste.htm
> 
> I'm holding off for now, though, because it's not clear that
> we're done discussing it. John and Ima seem certain that it's
> an improvement, but JC couldn't even compile it (more details
> on that anyone?).
> 
> Eric Lavigne
> 
> <snip>
>