Re: [Plib-devel] Another New Demo Program for PW
Brought to you by:
sjbaker
From: Steve B. <sjb...@ai...> - 2004-04-28 01:02:21
|
Fay John F Contr AAC/WMG wrote: > I have a couple of notes on your changes. The first is that the > "%lf" is good for the "printf" statements but we need to be careful with the > "sscanf" statements. I've put in a "float_value" variable which actually > gets read from the strings. Yep. > The second is a PW issue which I think I raised earlier. The fifth > argument of "pwInit" is "int multisample" which in the "pw_demo" program is > set to "false". I think an "int" should be "TRUE" and "FALSE" rather than > the strict boolean values of "true" and "false". I propose that we either > change the "pwInit" function to take a "bool" or else we change "pw.h" to > include definitions of "TRUE" and "FALSE" and change the sample programs to > pass those. My personal preference is for the latter. Actually, we should probably step back and think a bit more about that. When you turn on multisampling, there is generally a choice as to the number of subsamples - and sometimes other qualitative parameters. Perhaps we should change it to some kind of enumeration such that zero means "no multisampling", one means "best possible multisampling" and other values could be added later. This would keep existing programs working - but allow for more fancy stuff later. ---------------------------- Steve Baker ------------------------- HomeEmail: <sjb...@ai...> WorkEmail: <sj...@li...> HomePage : http://www.sjbaker.org Projects : http://plib.sf.net http://tuxaqfh.sf.net http://tuxkart.sf.net http://prettypoly.sf.net -----BEGIN GEEK CODE BLOCK----- GCS d-- s:+ a+ C++++$ UL+++$ P--- L++++$ E--- W+++ N o+ K? w--- !O M- V-- PS++ PE- Y-- PGP-- t+ 5 X R+++ tv b++ DI++ D G+ e++ h--(-) r+++ y++++ -----END GEEK CODE BLOCK----- |