Re: [Plib-devel] Re: [PATCH] ssg/ssgLoadAC.cxx: fix potential crash; accept DOS line endings

[James J. <jcp...@co...>]

On Thu, 2003-07-03 at 10:25, Melchior FRANZ wrote:
> * Melchior FRANZ -- Thursday 03 July 2003 11:12:
> > * Bernie Bright -- Thursday 03 July 2003 11:04:
> > > Instead of the specific patch to do_data() what if skip_space() actually
> > > skipped all whitespace characters instead of just ' ' and '\t':
> > 
> > No. skip_space is applied to a string pointer, while in do_data
> > we are directly reading from a stream. There would have to be
> > a lot more to rewrite to make your suggestion work.
> 
> OK, I was exaggerating quite a bit. Yes, do_data does directly
> read from the fd, but there's no need to do so. You won. Attached
> is a better fix. It should behave exactly as the original function.
> But it doesn't swallow an arbitrary number of trailing \n and \r,
> but only one set, which should suffice.
> 

This patch and the two from Martin Spott for Solaris have been applied
to CVS.

Thanks, folks!

-- 
James 'J.C.' Jones
 We are Pentium of Borg. Division is futile. You will be approximated.