Re: [plexil-support] [EXTERNAL] Patches to use the library

[Dalal, M. (ARC-TI)[K. W. S. LLC] <mic...@na...>]

Hi Martin,

We appreciate your interest in and use of PLEXIL, and any contributions you are willing to make!

Let me suggest an alternate approach for submitting your patches.  Fork the PLEXIL repository, put the patch on a branch in the forked repo, and then submit a GitHub pull request from the fork’s branch to the target branch on the server that you based the patch on, e.g. releases/plexil-4.6.

This may be easier than creating patch files, and is a more standard workflow for GitHub.  Indeed we need to establish and document a process for external contributions.

Best,
Mike

K. Michael Dalal
Lead, OceanWATERS (github.com/nasa/ow_simulator)
Autonomous Systems and Robotics, Code TI
KBR Inc. at NASA Ames Research Center
* Opinions expressed herein are only my own *



On 3/20/23, 9:11 AM, "Fry, Charles R. {Chuck} (ARC-TI)[KBR Wyle Services, LLC] via plexil-support" <ple...@li...<mailto:ple...@li...>> wrote:

Hello Martin. The PLEXIL team intended that users could write their own applications using the interfaces in the app-framework library. We realize this is not as well documented as it should be.

PLEXIL is intended to be compliant with C++ and POSIX standards, and is developed and maintained on multiple Linux distributions. Which Linux distro were you using, and on what hardware?

We would be interested in reviewing and possibly incorporating your changes. Could you please send them to us as patch files?

Thank you very much!

-- Chuck

Charles R. (Chuck) Fry - he/him/his
chu...@na...<mailto:chu...@na...>
Qualified Technical Services Inc. at Ames Research Center Code TI
Not speaking for QTS, KBR Wyle, Code TI, or NASA.


On 3/20/23, 4:24 AM, "Martin Fritsche" <mfr...@ro...<mailto:mfr...@ro...>> wrote:

Hi,
I tried to use Plexil as a library and link it to my own application (not using UniversalExec). This seems not to be the usual way, but I managed to do it with reading some code of UniversalExec and the library.
Still, I had to make a few patches to minimize crashing and remove some warnings. Are you interested in those? They are based on Plexil 4.6d0 and at least are functional with Linux (other OSs probably are a problem for one of them). If you are interested, what is the best way to make them available to you? I couldn’t find instructions for contributing.

Best,
Martin

Martin Fritsche
Software Engineer
Subsea Solutions
Creation Center

Phone +49-421-200957-09
Mobile +49-151-2645-2573
mfr...@ro...<mailto:mfr...@ro...>

ROSEN Creation Center GmbH
Branch Office Bremen
Arberger Hafendamm 22
28309 Bremen · GERMANY
www.rosen-group.com<https://gcc02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.rosen-group.com%2F&data=05%7C01%7Cmichael.dalal%40nasa.gov%7C1c466ad93af2460522d508db295dc22a%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C638149254909249259%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pSBCU7FPqpjJM5ErY5B2CdEgykka458D1x6V1zbbaD8%3D&reserved=0>
[Image removed by sender.]


This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. This e-mail address is provided for business correspondence only. It is not to be used for promotional or bulk mail, or given or sold to a third party for any purpose.