#260 Player CVS: memory related errors in nav200

closed
Player (393)
5
2008-04-13
2008-03-02
No

I must warn that I don't have means to test if it works, whole this patch is based only on my programming experience. At least it compiles fine. I've found these bugs looking for something else:
1. If new is used, delete must be used somewhere else (but see comment below)
2. If strdup() is used, free() must be used somewhere else (but see comment below)
3. Using static variables in multithreaded program leads directly to big troubles

According to Publish() logic, free() and delete must not be called if the last parameter equals to false. However this parameter defaults to true and it is used so in this case.
I was working with CVS snapshot taken 2008.03.02.

Discussion

  • Paul Osmialowski

    player-20080302/server/drivers/position/nav200/sicknav200.cc

     
  • Brian Gerkey

    Brian Gerkey - 2008-03-12
    • labels: --> Player
    • assigned_to: nobody --> gerkey
     
  • Toby Collett

    Toby Collett - 2008-04-13
    • status: open --> closed
     
  • Toby Collett

    Toby Collett - 2008-04-13

    Logged In: YES
    user_id=974361
    Originator: NO

    applied equivalent fixes to driver

     

Log in to post a comment.