From: <rav...@us...> - 2011-09-24 13:26:27
|
Revision: 7657 http://planeshift.svn.sourceforge.net/planeshift/?rev=7657&view=rev Author: ravna-ps Date: 2011-09-24 13:26:21 +0000 (Sat, 24 Sep 2011) Log Message: ----------- Added a missing security check and made the list sorted by name. Modified Paths: -------------- www/webconsole-new/crafting/checkminditemusage.php Modified: www/webconsole-new/crafting/checkminditemusage.php =================================================================== --- www/webconsole-new/crafting/checkminditemusage.php 2011-09-23 20:22:09 UTC (rev 7656) +++ www/webconsole-new/crafting/checkminditemusage.php 2011-09-24 13:26:21 UTC (rev 7657) @@ -2,14 +2,18 @@ function checkMindItemUsage() { + if (!checkaccess('crafting', 'read')) + { + echo '<p class="error">You are not authorized to use these functions</p>'; + } if (!isset($_GET['full_list'])) { - echo '<p class="error">This page takes a lot of server resources to load, only use it if you really need it. If you only need to edit'; + echo '<p class="error">This page takes a lot of server resources to load, only use it if you really need it. If you only need to edit '; echo '(or view) 1 item, please use the list below, or change it directly at the patterns page.<br/>'; echo 'click <a href="./index.php?do=checkminditemusage&full_list">here</a> to load the full page. </p>'; } - $query = "SELECT id, name, category_id FROM item_stats WHERE stat_type = 'B' AND valid_slots LIKE '%MIND%'"; + $query = "SELECT id, name, category_id FROM item_stats WHERE stat_type = 'B' AND valid_slots LIKE '%MIND%' ORDER BY name"; $result = mysql_query2($query); while($row = mysql_fetch_array($result, MYSQL_ASSOC)) { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <rav...@us...> - 2011-09-24 13:28:12
|
Revision: 7658 http://planeshift.svn.sourceforge.net/planeshift/?rev=7658&view=rev Author: ravna-ps Date: 2011-09-24 13:28:06 +0000 (Sat, 24 Sep 2011) Log Message: ----------- If one "fixes" a missing security check, one should do it properly. :) Modified Paths: -------------- www/webconsole-new/crafting/checkminditemusage.php Modified: www/webconsole-new/crafting/checkminditemusage.php =================================================================== --- www/webconsole-new/crafting/checkminditemusage.php 2011-09-24 13:26:21 UTC (rev 7657) +++ www/webconsole-new/crafting/checkminditemusage.php 2011-09-24 13:28:06 UTC (rev 7658) @@ -5,6 +5,7 @@ if (!checkaccess('crafting', 'read')) { echo '<p class="error">You are not authorized to use these functions</p>'; + return; } if (!isset($_GET['full_list'])) { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <rav...@us...> - 2011-09-24 13:54:20
|
Revision: 7659 http://planeshift.svn.sourceforge.net/planeshift/?rev=7659&view=rev Author: ravna-ps Date: 2011-09-24 13:54:14 +0000 (Sat, 24 Sep 2011) Log Message: ----------- Added pattern name + link to the mind item usage check. Modified Paths: -------------- www/webconsole-new/crafting/checkminditemusage.php Modified: www/webconsole-new/crafting/checkminditemusage.php =================================================================== --- www/webconsole-new/crafting/checkminditemusage.php 2011-09-24 13:28:06 UTC (rev 7658) +++ www/webconsole-new/crafting/checkminditemusage.php 2011-09-24 13:54:14 UTC (rev 7659) @@ -14,11 +14,19 @@ echo 'click <a href="./index.php?do=checkminditemusage&full_list">here</a> to load the full page. </p>'; } - $query = "SELECT id, name, category_id FROM item_stats WHERE stat_type = 'B' AND valid_slots LIKE '%MIND%' ORDER BY name"; + $query = "SELECT i.id, i.name, i.category_id, p.id AS pattern_id, p.pattern_name FROM item_stats AS i LEFT JOIN trade_patterns AS p ON i.id=p.designitem_id WHERE i.stat_type = 'B' AND i.valid_slots LIKE '%MIND%' ORDER BY i.name"; $result = mysql_query2($query); while($row = mysql_fetch_array($result, MYSQL_ASSOC)) { - echo '<p><a href="./index.php?do=listitems&override1&category='.$row['category_id'].'&item='.$row['id'].'">'.$row['name'].'</a><br/>'; + echo '<p><a href="./index.php?do=listitems&override1&category='.$row['category_id'].'&item='.$row['id'].'">'.$row['name'].'</a> '; + if ($row['pattern_name'] == null) + { + echo '(<span class="error">Not used in a pattern pattern</span>)<br/>'; + } + else + { + echo '(pattern: <a href="./index.php?do=editpattern&id='.$row['pattern_id'].'">'.$row['pattern_name'].'</a>)<br/>'; + } if(isset($_GET['full_list'])) { $item_id = $row['id']; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <rav...@us...> - 2011-09-24 15:37:26
|
Revision: 7660 http://planeshift.svn.sourceforge.net/planeshift/?rev=7660&view=rev Author: ravna-ps Date: 2011-09-24 15:37:21 +0000 (Sat, 24 Sep 2011) Log Message: ----------- Added a note about execution time, patience is key. Modified Paths: -------------- www/webconsole-new/crafting/checkminditemusage.php Modified: www/webconsole-new/crafting/checkminditemusage.php =================================================================== --- www/webconsole-new/crafting/checkminditemusage.php 2011-09-24 13:54:14 UTC (rev 7659) +++ www/webconsole-new/crafting/checkminditemusage.php 2011-09-24 15:37:21 UTC (rev 7660) @@ -9,9 +9,9 @@ } if (!isset($_GET['full_list'])) { - echo '<p class="error">This page takes a lot of server resources to load, only use it if you really need it. If you only need to edit '; - echo '(or view) 1 item, please use the list below, or change it directly at the patterns page.<br/>'; - echo 'click <a href="./index.php?do=checkminditemusage&full_list">here</a> to load the full page. </p>'; + echo '<p>This page takes a lot of server resources to load, only use it if you really need it. (And use it wisely, on a test server instead of the main.) '; + echo 'If you only need to edit (or view) 1 item, please use the list below, or change it directly at the patterns page.<br/>'; + echo 'click <a href="./index.php?do=checkminditemusage&full_list">here</a> to load the full page. (<span class="error">This may take in excess of 5 minutes to load.</span>) </p>'; } $query = "SELECT i.id, i.name, i.category_id, p.id AS pattern_id, p.pattern_name FROM item_stats AS i LEFT JOIN trade_patterns AS p ON i.id=p.designitem_id WHERE i.stat_type = 'B' AND i.valid_slots LIKE '%MIND%' ORDER BY i.name"; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <rav...@us...> - 2011-09-24 23:11:22
|
Revision: 7661 http://planeshift.svn.sourceforge.net/planeshift/?rev=7661&view=rev Author: ravna-ps Date: 2011-09-24 23:11:16 +0000 (Sat, 24 Sep 2011) Log Message: ----------- Added a notice about the way quest usage is determined. Modified Paths: -------------- www/webconsole-new/crafting/checkminditemusage.php Modified: www/webconsole-new/crafting/checkminditemusage.php =================================================================== --- www/webconsole-new/crafting/checkminditemusage.php 2011-09-24 15:37:21 UTC (rev 7660) +++ www/webconsole-new/crafting/checkminditemusage.php 2011-09-24 23:11:16 UTC (rev 7661) @@ -13,6 +13,10 @@ echo 'If you only need to edit (or view) 1 item, please use the list below, or change it directly at the patterns page.<br/>'; echo 'click <a href="./index.php?do=checkminditemusage&full_list">here</a> to load the full page. (<span class="error">This may take in excess of 5 minutes to load.</span>) </p>'; } + else + { + echo '<p>Notice that the quests listed are determined using wildcard searches, and may match anything that includes the item name. So an item called "book", will also match a quest giving you "book of blades".</p>'; + } $query = "SELECT i.id, i.name, i.category_id, p.id AS pattern_id, p.pattern_name FROM item_stats AS i LEFT JOIN trade_patterns AS p ON i.id=p.designitem_id WHERE i.stat_type = 'B' AND i.valid_slots LIKE '%MIND%' ORDER BY i.name"; $result = mysql_query2($query); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |