Re: [Pipmak-Devel] Diff file

[Christian W. <cwa...@gm...>]

Andrea, I've applied and cleaned up your patches. Windows registry 
manipulation is commited, thanks! Please test.

The other one appears to work well, but I haven't committed it yet 
because the following occurred to me when I tested it: wouldn't it be 
better to have pipmak.getscreenmodes() return
   {{1440, 900}, {1280, 800}, ... }
instead of
   {{w = 1440, h = 900}, {w = 1280, h = 800}, ... } ?

That way, you could directly say
   modes = pipmak.getscreenmodes()
   pipmak.setfullscreen(unpack(modes[i]))


Some general comments:

- For newly written code, please stick to the coding style of the 
surrounding code: a space after a comma; multi-word identifiers fused 
using CamelCase, not with underscores; opening braces on the same line; 
indentation with tabs, not spaces; a space after "if"; single-line 
if-else branches either on the same line or surrounded with {}; no space 
after opening parenthesis and before closing parenthesis (unless there 
are many of them and it helps readability to group them); spaces around 
"=", "==" etc.

- I won't commit this hack (but of course you can keep it in your 
working copy until someone fixes the bug with that function and MSVC):
> +#ifndef _MSC_VER
>  	checkinstanceof(L, 1, "pipmak-node", "node");
> +#endif

- Patches that include documentation tend to make it into SVN faster 
because I don't have to write it first.


  -Christian