Re: [Pipmak-Devel] Build 157

[Christian W. <cwa...@gm...>]

Andrea Viarengo wrote:
> I have tried to compile your last build (157)
> It compile right on MSVC without any source modification,
> 
> I have only added definition on command line:
> 
> /D _USE_MATH_DEFINES     (to permit the use of M_PI)
> /D _CRT_SECURE_NO_DEPRECATE
> 
> Do You think we could  put them in some "*.h" file inside a block #ifdef 
> _MSC_VER?

Sure. That's what config.h is for. You probably need to double-check 
whether it's included in all files that need it.

> The other thing I have done is set /fp:fast (the default is /fp:precise) 
> this reduce number of warning,
> otherwise all float constants are treat as double.

Treating float constants without a type suffix as doubles is correct. If 
that causes warnings because such constants are used as floats, then 
these need to be fixed (by adding an "f" to the constant).

Could you prepare a patch with these changes, to fix as many of your 
warnings as possible? That's easier than going through multiple 
iterations of me committing guesswork and you testing it.

> P.S.: I din't manage anymore to reach SVN repository via web using
> http://svn.sourceforge.net/pipmak
> but I have to use http://pipmak.svn.sourceforge.net/viewvc/pipmak

Good catch, thanks. I've changed that. It's indeed a permanent change.

> d:\projects\pipmak-svn-157\source\pipmak_windows.c(179) : warning C4311: 
> 'cast di tipo': troncamento puntatore da 'HINSTANCE' a 'int'
> d:\projects\pipmak-svn-157\source\pipmak_windows.c(182) : warning C4311: 
> 'cast di tipo': troncamento puntatore da 'HINSTANCE' a 'int'
> d:\projects\pipmak-svn-157\source\pipmak_windows.c(185) : warning C4311: 
> 'cast di tipo': troncamento puntatore da 'HINSTANCE' a 'int'

I don't know what to do about these. Microsoft's documentation 
explicitly states that the result of ShellExecute() should be cast to int...

> d:\projects\pipmak-svn-157\source\textedit.c(463) : warning C4090: 
> 'funzione': qualificatori 'const' differenti
> d:\projects\pipmak-svn-157\source\textedit.c(535) : warning C4090: 
> 'funzione': qualificatori 'const' differenti

Update to SDL 1.2.12.


  -Christian