Re: [Pipmak-Devel] Diff file

[Andrea V. <and...@gm...>]

> Thanks. Haven't had time to check it yet. It applies cleany except for 
> the removal of the imageLineLua() function which isn't there in SVN. 

AAArgh!!

Sorry, it's escaped to me, it was just a test (failed), probably 
I have modified the wrong "pipmakLuaLib.c". 
I believed to start from a clean source-prepatch!!

however, imageLineLua() it does't have to exist.

if you have problem to apply patch I can re-send a more clean patch-file.

Do you have checked my compilation log which you have requested about
conversion warning?
(http://pipmak.sourceforge.net/wiki/index.php/Build_log_156)

There are a lot of warning caused by statements like:

h = y - h*M_PI/180;

where h,y are float but M_PI are double  

other:

glVertex3f(cos(y)*sin(w), sin(y), -cos(y)*cos(w));

glVertex3F(Glfloat,Glfloat,Glfloat)

but  cos(y)*sin(w) is double


screenViewMatrix[5] = -2.0/screen->h;

in this case the warning disapear changing line with

screenViewMatrix[5] = -2.0f/screen->h;

This is different

    if (i+N>len) goto done;

the warning tell: wrong correspondence between signed and unsigned

I don't know if is better introduce some casting or leave the warnings.
What do you think?

Andrea