Re: Bug in r205
Status: Alpha
Brought to you by:
cwalther
From: Christian W. <cwa...@gm...> - 2008-10-18 10:23:49
|
Andrea Viarengo wrote: > If I don't include them, Pipmak-r205 works exactly as Pipmak-0.2.7 and > crash in the same manner. OK, how about r207? What triggered the crash that I fixed there was your call "pipmak.overlaynode(2)" in main.lua, at a time when there's no background node yet. That was fortunate insofar as it pointed us to this bug, but otherwise doing such things in main.lua is a bad idea. You shouldn't assume that main.lua is run exactly once when the project is opened. That's currently the case, but it may change in the future. Initialization procedures belong in onopenproject(). In a way, main.lua should be treated as a data file, not as a program, and running it should have no side effects. Apart from that, overlaying a node when there's no background node yet doesn't make much sense to me, but as it happens to work the way you want (the real background node is later inserted under it), modulo undiscovered bugs, I decided to keep it allowed for the time being. But for my taste, the proper place for that would be onenternode() of the main node. I'm still uncertain about the cause of the random reproducibility of the crash, there might be another bug lurking there. Will investigate further. -Christian |