Re: [Pipmak-Devel] Two Bugs

[Christian W. <cwa...@gm...>]

Aidan Gauland wrote:
> I have (I think) fixed the bug with the mouse grabbing.  If I remove the 
> call to SDL_WM_GrabInput() that's right before the main for(;;) loop, 
> then it seems to always be possible to get the mouse out of the window, 
> even with edge resistance.

Thanks, I've committed that. That grab must have been a relic from the 
past, the automatic grab when the mouse moves inside the window is 
indeed sufficient.

> Also, when I bring up the save game dialog with the 'S' key, Pipmak 
> doesn't give me my mouse back, and I have to go to a virtual console and 
> kill Pipmak.  If I add a call to SDL_WM_GrabInput() to ungrab the mouse 
> in the Lua C function which is called when the 'S' key is pressed, that 
> seems to solve this problem.

Right, that was an oversight. The other two dialogs (open project and 
open saved game) have the ungrab. For some reason it worked here on Mac 
OS X without it. This is committed, thanks!

> I also added parentheses around the tests for an if statement (you'll 
> see where), just to suppress a complier warning.  No other reason.

GCC doesn't trust us to know that 'and' is stronger than 'or'? Oh 
well... applied.

  -Christian