Re: [Pipmak-Devel] another way of measuring the mouse speed

[Christian W. <cwa...@gm...>]

Aidan Gauland wrote:
>   I applied the patch, and it works perfectly fine on my system.  I  
> also added a printf() just after each call to SDL_WM_GrabInput, so I  
> could confirm that Pipmak was grabbing and releasing the mouse when  
> it should.  And yes, I do like that behaviour.

Fine, then I'll commit that. I'm sorry you had to do all the hard work  
with timing and stuff before we found that simple solution.

>  Is anyone working on the bug with mouse clicks during transitions?

Not that I know of. I expect that to be a simple one. One thing you  
should double-check is if there are any hidden assumptions in the code  
along the lines of "there's exactly one mouse up event for every mouse  
down event", which you could violate by ignoring some events. Off the  
top of my head, I'd say this is already taken care of by the code that  
does things like coalescing multiple mouse buttons into one, but it  
can't hurt to check that nothing unexpected happens when e.g. the  
mouse goes down during a transition and up after it, or down before  
and up during.

> If not, then where could I start on that one?  I know where the  
> event handling case statement is for mouse clicks (at least, I think  
> it's near the one for mouse motion events), but where is the code  
> for display transitions?

Check the switch statement in the last few lines of main.c. Depending  
on whether a transition is in progress, redrawGL() is called there  
either with an argument of 1.0 ("render normally") or with an argument  
between 0.0 and 1.0 ("render a transition effect").

A case-insensitive search for "transition" in the whole source code  
may help you get an overview too.

   -Christian