From: Mike H. <mh...@uc...> - 2009-05-11 08:54:14
|
One problem I do see with it however is I do need the list of parents to figure out the failure point in the "determine why a job hasn't started" function, soooo just having a job won't work, but having it extend a job might. Mike On May 11, 2009, at 1:30 AM, Mike Hess <mh...@uc...> wrote: > Yea you're probably right. I'll fix it tomorrow. Shouldn't be that > hard to implements, I just did it a quick dirty way. Could a > JobStatusReport just have a Job that it can access the data of, then a > couple of print functions? Because I could do that in like 15 > minutes. > > -Mike > > On May 11, 2009, at 12:44 AM, Chris Swan wrote: > >> Nice work so far! I haven't given the code a real review yet, but >> one thing >> I think we should decide is whether the primary logic for these >> functions >> belongs in the Manager or in the Workflow/Job itself. I see a few >> ways to do >> this: >> >> 1) The current way (or at least my understanding of it): From within >> the >> WorkflowManager, iterate over the jobs >> >> 2) A way that promotes the "smart nodes, dumb consumers" idea: The >> Manager >> calls workflow.PrintStatus(), the Workflow calls Job.printStatus(), >> etc., >> and the workflow/jobs print themselves. >> >> 3) Probably the best way overall: The Manager calls >> workflow.GetStatus(), >> which returns a data structure containing all the relevant >> information -- >> essentially, a list of "JobStatusReport" objects that contain all the >> information about the job, but without the parent/children >> information. The >> Manager can then iterate over this data structure in order to print >> the >> info. The benefit of this way is that we can use this very same code >> to make >> our GUI app, only changing what we do as we iterate. All of the >> intelligence >> is still maintained within the Workflow/Job. >> >> Maybe for now this isn't a high priority, but I do think we should >> try to >> avoid ever directly looking at the job's parents and children. Those >> should >> be private and not have a public accessor. In the meantime, maybe we >> can >> make the Manager's reporting module into a friend class. >> >> What do you guys think? >> >> -Chris >> >> -------------------------------------------------- >> From: "Mike Hess" <mh...@uc...> >> Sent: Sunday, May 10, 2009 2:27 PM >> To: "CS 130" <pip...@li...> >> Subject: [Pipeline130-developers] Any other status functions? >> >>> Hey I was wondering if you guys had any other status functions that >>> you guys can think of. >>> One's I've implemented are: >>> Take in a workflow and print out status of all its Jobs >>> Take in a workflow and print out jobs that are holding up completion >>> Take in a job and print out why the job hasn't started >>> >>> >>> Also I had to mess around with some other classes and I wanted to >>> make >>> sure its OK how I did it. I took the JobStatus enum out of the Job >>> class and made it its own file because it wasn't letting me access >>> it. I also added functions that return a Job's parents and return a >>> workflow's jobs so I could access them. >>> >>> >>> -Mike >>> >>> --- >>> --- >>> --- >>> --- >>> ------------------------------------------------------------------ >>> The NEW KODAK i700 Series Scanners deliver under ANY circumstances! >>> Your >>> production scanning environment may not be a perfect world - but >>> thanks to >>> Kodak, there's a perfect scanner to get the job done! With the NEW >>> KODAK >>> i700 >>> Series Scanner you'll get full speed at 300 dpi even with all image >>> processing features enabled. http://p.sf.net/sfu/kodak-com >>> _______________________________________________ >>> Pipeline130-developers mailing list >>> Pip...@li... >>> https://lists.sourceforge.net/lists/listinfo/pipeline130-developers >>> >> >> --- >> --- >> --- >> --------------------------------------------------------------------- >> The NEW KODAK i700 Series Scanners deliver under ANY circumstances! >> Your >> production scanning environment may not be a perfect world - but >> thanks to >> Kodak, there's a perfect scanner to get the job done! With the NEW >> KODAK i700 >> Series Scanner you'll get full speed at 300 dpi even with all image >> processing features enabled. http://p.sf.net/sfu/kodak-com >> _______________________________________________ >> Pipeline130-developers mailing list >> Pip...@li... >> https://lists.sourceforge.net/lists/listinfo/pipeline130-developers > > > --- > --- > --- > --------------------------------------------------------------------- > The NEW KODAK i700 Series Scanners deliver under ANY circumstances! > Your > production scanning environment may not be a perfect world - but > thanks to > Kodak, there's a perfect scanner to get the job done! With the NEW > KODAK i700 > Series Scanner you'll get full speed at 300 dpi even with all image > processing features enabled. http://p.sf.net/sfu/kodak-com > _______________________________________________ > Pipeline130-developers mailing list > Pip...@li... > https://lists.sourceforge.net/lists/listinfo/pipeline130-developers |