From: Brian S. <br...@bo...> - 2007-02-23 14:25:42
|
I would like to bring up the point about style. Right now we have multiple formatting styles including Randy's own... uhm... interesting style that he applied to the CountAccessor when he added types to it. :) We should probably standardize on something idiommatic and apply CheckStyle. Additionally, as this is a dual-purpose module to demonstrate how to do these things, I would like to suggest that we don't use the .* import notation since that makes it more difficult for people not using IDEs to find where things come from. I plan on being aggressive with Eclipse's Organize Imports feature. Just want to throw that out there. Congrats on the first release. I'm going to demonstrate Pinky as part of a new Data integration talk at the NFJS shows this year. |