#4 Makefile - PREFIX and DEVKITARM and some compiler warnings

[declis]

I'm using DevkitPro r43 and had to modify the makefile at some points:

new PREFIX: "PREFIX ?= arm-none-eabi-"
new DEVKITARM: "DEVKITARM = $(DEVKITPRO)/devkitARM/bin"

Downloaded pimpmobile_r1.tar with example/example.c and there are some casting errors because of the .c file (.cpp is ok of course, and there is a .cpp file in the Code section on sourceforge):

"make"
arm-none-eabi-gcc -I/E/devkitPro/devkitARM/include -I/E/devkitPro/libgba/include -IE:/eigenedateien/GBA/pimpmobile/include -DRELEASE -DNDEBUG -mthumb-interwork -mlong-calls -O3 -fomit-frame-pointer -mthumb -c example.c -o example.o -MMD -MP -MF example.d
example.c: In function 'report':
example.c:44:18: error: expected expression before 'float'
float percent = float(accum * 100) / (1 << 24);
^
example.c:45:39: error: expected expression before 'int'
iprintf("cpu: %d.%03d%% (%d c/f)\n", int(percent), int(percent * 1000) % 1000, accum / 60);
^
"make": *** [example.o] Error 1

Here are some compiler warnings, I'm not sure if this is important or not:

"make"
make -C .. lib/libpimpmobile.a
make[1]: Entering directory `/e/eigenedateien/GBA/pimpmobile'
arm-none-eabi-gcc -I/E/devkitPro/devkitARM/bin/include -I/E/devkitPro/libgba/include -DRELEASE -DNDEBUG -mthumb-interwork -mlong-calls -O3 -fomit-frame-pointer -mthumb -c src/pimp_gba.c -o src/pimp_gba.o -MMD -MP -MF src/pimp_gba.d
src/pimp_gba.c:27:1: warning: variably modified 'pimp_sound_buffers' at file scope
static s8 pimp_sound_buffers[2][SOUND_BUFFER_SIZE] IWRAM_DATA;
^
src/pimp_gba.c:29:1: warning: variably modified 'pimp_mix_buffer' at file scope
s32 pimp_mix_buffer[SOUND_BUFFER_SIZE] IWRAM_DATA;
^
arm-none-eabi-gcc -I/E/devkitPro/devkitARM/bin/include -I/E/devkitPro/libgba/include -DRELEASE -DNDEBUG -mthumb-interwork -mlong-calls -O3 -fomit-frame-pointer -mthumb -c src/pimp_render.c -o src/pimp_render.o -MMD -MP -MF src/pimp_render.d
arm-none-eabi-gcc -I/E/devkitPro/devkitARM/bin/include -I/E/devkitPro/libgba/include -DRELEASE -DNDEBUG -mthumb-interwork -mlong-calls -O3 -fomit-frame-pointer -mthumb -c src/pimp_envelope.c -o src/pimp_envelope.o -MMD -MP -MF src/pimp_envelope.d
arm-none-eabi-gcc -I/E/devkitPro/devkitARM/bin/include -I/E/devkitPro/libgba/include -DRELEASE -DNDEBUG -mthumb-interwork -mlong-calls -O3 -fomit-frame-pointer -mthumb -c src/pimp_debug.c -o src/pimp_debug.o -MMD -MP -MF src/pimp_debug.d
arm-none-eabi-gcc -I/E/devkitPro/devkitARM/bin/include -I/E/devkitPro/libgba/include -DRELEASE -DNDEBUG -mthumb-interwork -mlong-calls -O3 -fomit-frame-pointer -mthumb -c src/pimp_mod_context.c -o src/pimp_mod_context.o -MMD -MP -MF src/pimp_mod_context.d
arm-none-eabi-gcc -I/E/devkitPro/devkitARM/bin/include -I/E/devkitPro/libgba/include -DRELEASE -DNDEBUG -mthumb-interwork -mlong-calls -O3 -fomit-frame-pointer -marm -c src/pimp_math.c -o src/pimp_math.iwram.o -MMD -MP -MF src/pimp_math.iwram.d
arm-none-eabi-gcc -I/E/devkitPro/devkitARM/bin/include -I/E/devkitPro/libgba/include -DRELEASE -DNDEBUG -mthumb-interwork -mlong-calls -O3 -fomit-frame-pointer -marm -c src/pimp_mixer.c -o src/pimp_mixer.iwram.o -MMD -MP -MF src/pimp_mixer.iwram.d
arm-none-eabi-gcc -mthumb-interwork -I/E/devkitPro/devkitARM/bin/include -I/E/devkitPro/libgba/include -DRELEASE -DNDEBUG -c -o src/pimp_mixer_arm.o src/pimp_mixer_arm.S
arm-none-eabi-gcc -mthumb-interwork -I/E/devkitPro/devkitARM/bin/include -I/E/devkitPro/libgba/include -DRELEASE -DNDEBUG -c -o src/pimp_mixer_clip_arm.o src/pimp_mixer_clip_arm.S
src/pimp_mixer_clip_arm.S: Assembler messages:
src/pimp_mixer_clip_arm.S:156: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:158: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:165: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:167: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:174: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:176: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:189: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:191: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:196: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:198: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:203: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:205: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:210: Warning: s suffix on comparison instruction is deprecated
src/pimp_mixer_clip_arm.S:212: Warning: s suffix on comparison instruction is deprecated

[Erik Faye-Lund]

First of all, pimpmobile now lives on GitHub (https://github.com/kusma/pimpmobile). I should probably update the website etc to reflect this... If I can figure out how ;)

Secondly, pimpmobile_r1.tar is quite outdated, the latest git repository has C++ examples rather than C. Further, those "variably modified"-warnings seems bogus, as there's nothing forcing IWRAM-data to be const, probably an issue in the devkitPro port. I also cannot find any s-suffixes on comparison instructions in the latest git-version.

Anyway, thanks for taking the time to report these issues :)

[declis]

Oops! Alright, I found pimpmobile here http://www.pouet.net/topic.php?which=5346&page=1 and simply started to compile it etc. Tested it on real hardware tonight (GBA-SP) and everything seems to be ok http://picload.org/image/cialrgp/20150128_142216.jpg. Thanks for the informations!