Re: [pilot-db-list] CVS indentation strategy

[Emmanuel S. <se...@wa...>]

On Sat, Feb 21, 2004 at 08:51:22PM -0700, Nathan Kurz wrote:
>
> As I start to do things with the CVS repository, it's apparent that
> Scott and Tom had different opinions on how indent C code.  The
> obvious difference is that Scott preferred 8 space indents, while the
> rest of the code (presumably mostly Tom's) has 4 space indents.

I'm more of a K&R style (8 space indents, braces on the end of the line)
fan myself but hey...

> The current code is often hard to read, because the indentation might
> change several times withing a given function.  Personally, I prefer
> GNU style with 2 space indents, but changing over to this would be
> silly.  So what is to be done?  My impulse is to restandardize to
> Tom's original 4 space indentation.

Probably best to change to whatever is more present in the code at the
moment. Makes for less work.

> Thoughts appreciated, although practical suggestions would be
> appreciated more than blind zealotry.  Left to my own devices, I'll
> probably just start re-indenting files before I start working on them,
> checking them in, and then checking my changes in on top of that.

This is absolutely vital, IMHO.
Submit a indentation fix to CVS, noting in the logs that there has been
no code change then make a second commit with your changes.

Emmanuel