Thread: [Pieforms-commit] SF.net SVN: pieforms: [101] pieforms-php5/trunk/src/pieform/renderers/table .php
Status: Alpha
Brought to you by:
oracleshinoda
Menu
▾
▴
pieforms-commit
|
From: <ora...@us...> - 2006-12-17 23:27:44
|
Revision: 101
http://svn.sourceforge.net/pieforms/?rev=101&view=rev
Author: oracleshinoda
Date: 2006-12-17 15:27:39 -0800 (Sun, 17 Dec 2006)
Log Message:
-----------
Use the new, smarter way of putting a message next to the correct submit button
Modified Paths:
--------------
pieforms-php5/trunk/src/pieform/renderers/table.php
Modified: pieforms-php5/trunk/src/pieform/renderers/table.php
===================================================================
--- pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-17 23:26:45 UTC (rev 100)
+++ pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-17 23:27:39 UTC (rev 101)
@@ -106,7 +106,7 @@
return "</tbody></table>\n";
}
-function pieform_renderer_table_messages_js($id, $submitid) {
+function pieform_renderer_table_messages_js($id) {
$result = <<<EOF
// Given a message and form element name, should set an error on the element
function {$id}_set_error(message, element) {
@@ -135,7 +135,7 @@
swapDOM(elem, msg);
}
else {
- appendChildNodes($('{$id}_{$submitid}_container').parentNode, msg);
+ appendChildNodes($('{$id}_' + {$id}_btn + '_container').parentNode, msg);
}
}
function {$id}_remove_message() {
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ora...@us...> - 2006-12-23 03:39:29
|
Revision: 106
http://svn.sourceforge.net/pieforms/?rev=106&view=rev
Author: oracleshinoda
Date: 2006-12-22 19:39:29 -0800 (Fri, 22 Dec 2006)
Log Message:
-----------
Made the tablerenderer work again with the changes made recently. It now also correctly sets the error class on elements have an error on them
Modified Paths:
--------------
pieforms-php5/trunk/src/pieform/renderers/table.php
Modified: pieforms-php5/trunk/src/pieform/renderers/table.php
===================================================================
--- pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-23 03:36:11 UTC (rev 105)
+++ pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-23 03:39:29 UTC (rev 106)
@@ -99,7 +99,7 @@
}
function pieform_renderer_table_header() {
- return "<table cellspacing=\"0\" border=\"0\"><tbody>\n";
+ return "<table cellspacing=\"0\"><tbody>\n";
}
function pieform_renderer_table_footer() {
@@ -108,21 +108,13 @@
function pieform_renderer_table_messages_js($id) {
$result = <<<EOF
-// Given a message and form element name, should set an error on the element
function {$id}_set_error(message, element) {
- {$id}_remove_error(element);
- element += '_container';
- // @todo set error class on input elements...
- $(element).parentNode.insertBefore(TR({'id': '{$id}_error_' + element}, TD({'colspan': 2, 'class': 'errmsg'}, message)), $(element).nextSibling);
+ element = '{$id}_' + element + '_container';
+ var container = getFirstElementByTagAndClassName('TD', null, $(element));
+ addElementClass(container, 'error');
+ addElementClass(container.firstChild, 'error');
+ insertSiblingNodesAfter($(element), TR({'id': '{$id}_error_' + element}, TD({'colspan': 2, 'class': 'errmsg'}, message)));
}
-// Given a form element name, should remove an error associated with it
-function {$id}_remove_error(element) {
- element += '_container';
- var elem = $('{$id}_error_' + element);
- if (elem) {
- removeElement(elem);
- }
-}
function {$id}_remove_all_errors() {
forEach(getElementsByTagAndClassName('TD', 'errmsg', $('$id')), function(item) {
removeElement(item.parentNode);
@@ -134,8 +126,8 @@
if (elem) {
swapDOM(elem, msg);
}
- else {
- appendChildNodes($('{$id}_' + {$id}_btn + '_container').parentNode, msg);
+ else if ({$id}_btn) {
+ insertSiblingNodesAfter($('{$id}_' + {$id}_btn + '_container'), msg);
}
}
function {$id}_remove_message() {
@@ -144,7 +136,6 @@
removeElement(elem);
}
}
-
EOF;
return $result;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ora...@us...> - 2006-12-23 05:10:44
|
Revision: 132
http://svn.sourceforge.net/pieforms/?rev=132&view=rev
Author: oracleshinoda
Date: 2006-12-22 21:10:44 -0800 (Fri, 22 Dec 2006)
Log Message:
-----------
Make sure the 'error' class is removed from elements when all errors are being removed
Modified Paths:
--------------
pieforms-php5/trunk/src/pieform/renderers/table.php
Modified: pieforms-php5/trunk/src/pieform/renderers/table.php
===================================================================
--- pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-23 05:09:20 UTC (rev 131)
+++ pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-23 05:10:44 UTC (rev 132)
@@ -119,6 +119,10 @@
forEach(getElementsByTagAndClassName('TD', 'errmsg', $('$id')), function(item) {
removeElement(item.parentNode);
});
+ forEach(getElementsByTagAndClassName('TD', 'error', $('$id')), function(item) {
+ removeElementClass(item, 'error');
+ removeElementClass(item.firstChild, 'error');
+ });
}
function {$id}_message(message, type) {
var elem = $('{$id}_pieform_message');
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ora...@us...> - 2006-12-23 13:13:06
|
Revision: 134
http://svn.sourceforge.net/pieforms/?rev=134&view=rev
Author: oracleshinoda
Date: 2006-12-23 05:13:02 -0800 (Sat, 23 Dec 2006)
Log Message:
-----------
Removed the messages functions, they are no longer needed. The function itself will later be renamed
Modified Paths:
--------------
pieforms-php5/trunk/src/pieform/renderers/table.php
Modified: pieforms-php5/trunk/src/pieform/renderers/table.php
===================================================================
--- pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-23 05:13:18 UTC (rev 133)
+++ pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-23 13:13:02 UTC (rev 134)
@@ -124,22 +124,6 @@
removeElementClass(item.firstChild, 'error');
});
}
-function {$id}_message(message, type) {
- var elem = $('{$id}_pieform_message');
- var msg = TR({'id': '{$id}_pieform_message'}, TD({'colspan': 2, 'class': type}, message));
- if (elem) {
- swapDOM(elem, msg);
- }
- else if ({$id}_btn) {
- insertSiblingNodesAfter($('{$id}_' + {$id}_btn + '_container'), msg);
- }
-}
-function {$id}_remove_message() {
- var elem = $('{$id}_pieform_message');
- if (elem) {
- removeElement(elem);
- }
-}
EOF;
return $result;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ora...@us...> - 2006-12-24 00:19:37
|
Revision: 137
http://svn.sourceforge.net/pieforms/?rev=137&view=rev
Author: oracleshinoda
Date: 2006-12-23 16:19:12 -0800 (Sat, 23 Dec 2006)
Log Message:
-----------
Slight improvements to the javascript for the table renderer
Modified Paths:
--------------
pieforms-php5/trunk/src/pieform/renderers/table.php
Modified: pieforms-php5/trunk/src/pieform/renderers/table.php
===================================================================
--- pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-24 00:18:11 UTC (rev 136)
+++ pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-24 00:19:12 UTC (rev 137)
@@ -109,11 +109,11 @@
function pieform_renderer_table_messages_js($id) {
$result = <<<EOF
function {$id}_set_error(message, element) {
- element = '{$id}_' + element + '_container';
- var container = getFirstElementByTagAndClassName('TD', null, $(element));
+ element = $('{$id}_' + element + '_container');
+ var container = getFirstElementByTagAndClassName('TD', null, element);
addElementClass(container, 'error');
addElementClass(container.firstChild, 'error');
- insertSiblingNodesAfter($(element), TR({'id': '{$id}_error_' + element}, TD({'colspan': 2, 'class': 'errmsg'}, message)));
+ insertSiblingNodesAfter(element, TR(null, TD({'colspan': 2, 'class': 'errmsg'}, message)));
}
function {$id}_remove_all_errors() {
forEach(getElementsByTagAndClassName('TD', 'errmsg', $('$id')), function(item) {
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ora...@us...> - 2006-12-27 04:58:00
|
Revision: 148
http://svn.sourceforge.net/pieforms/?rev=148&view=rev
Author: oracleshinoda
Date: 2006-12-26 20:58:00 -0800 (Tue, 26 Dec 2006)
Log Message:
-----------
Loosened the check for fieldsets a little bit so that classes can be added to the fieldset. Required for collapsable fieldset support
Modified Paths:
--------------
pieforms-php5/trunk/src/pieform/renderers/table.php
Modified: pieforms-php5/trunk/src/pieform/renderers/table.php
===================================================================
--- pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-26 00:28:16 UTC (rev 147)
+++ pieforms-php5/trunk/src/pieform/renderers/table.php 2006-12-27 04:58:00 UTC (rev 148)
@@ -38,7 +38,7 @@
$formname = $form->get_name();
if ($rawelement['type'] == 'fieldset') {
// Add table tags to the build element, to preserve HTML compliance
- if (0 === strpos($builtelement, "\n<fieldset>\n<legend>")) {
+ if (0 === strpos($builtelement, "\n<fieldset")) {
$closelegendpos = strpos($builtelement, '</legend>') + 9;
$builtelement = substr($builtelement, 0, $closelegendpos) . '<table>' . substr($builtelement, $closelegendpos);
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ora...@us...> - 2007-02-04 22:40:21
|
Revision: 175
http://svn.sourceforge.net/pieforms/?rev=175&view=rev
Author: oracleshinoda
Date: 2007-02-04 14:40:21 -0800 (Sun, 04 Feb 2007)
Log Message:
-----------
Handle having no legend better
Modified Paths:
--------------
pieforms-php5/trunk/src/pieform/renderers/table.php
Modified: pieforms-php5/trunk/src/pieform/renderers/table.php
===================================================================
--- pieforms-php5/trunk/src/pieform/renderers/table.php 2007-02-04 22:39:59 UTC (rev 174)
+++ pieforms-php5/trunk/src/pieform/renderers/table.php 2007-02-04 22:40:21 UTC (rev 175)
@@ -39,8 +39,15 @@
if ($rawelement['type'] == 'fieldset') {
// Add table tags to the build element, to preserve HTML compliance
if (0 === strpos($builtelement, "\n<fieldset")) {
- $closelegendpos = strpos($builtelement, '</legend>') + 9;
- $builtelement = substr($builtelement, 0, $closelegendpos) . '<table>' . substr($builtelement, $closelegendpos);
+ $closelegendpos = strpos($builtelement, '</legend>');
+ if ($closelegendpos !== false) {
+ $closelegendpos += 9;
+ $builtelement = substr($builtelement, 0, $closelegendpos) . '<table>' . substr($builtelement, $closelegendpos);
+ }
+ else {
+ $pos = strpos($builtelement, '>') + 1;
+ $builtelement = substr($builtelement, 0, $pos) . '<table>' . substr($builtelement, $pos);
+ }
}
else {
$builtelement = substr($builtelement, 0, 11) . '<table>' . substr($builtelement, 11);
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ora...@us...> - 2007-02-19 22:30:28
|
Revision: 188
http://svn.sourceforge.net/pieforms/?rev=188&view=rev
Author: oracleshinoda
Date: 2007-02-19 14:30:27 -0800 (Mon, 19 Feb 2007)
Log Message:
-----------
Added support for calling a help callback. Also added tbody tags to the renderer for IE's benefit
Modified Paths:
--------------
pieforms-php5/trunk/src/pieform/renderers/table.php
Modified: pieforms-php5/trunk/src/pieform/renderers/table.php
===================================================================
--- pieforms-php5/trunk/src/pieform/renderers/table.php 2007-02-19 22:23:32 UTC (rev 187)
+++ pieforms-php5/trunk/src/pieform/renderers/table.php 2007-02-19 22:30:27 UTC (rev 188)
@@ -42,17 +42,17 @@
$closelegendpos = strpos($builtelement, '</legend>');
if ($closelegendpos !== false) {
$closelegendpos += 9;
- $builtelement = substr($builtelement, 0, $closelegendpos) . '<table>' . substr($builtelement, $closelegendpos);
+ $builtelement = substr($builtelement, 0, $closelegendpos) . '<table><tbody>' . substr($builtelement, $closelegendpos);
}
else {
$pos = strpos($builtelement, '>') + 1;
- $builtelement = substr($builtelement, 0, $pos) . '<table>' . substr($builtelement, $pos);
+ $builtelement = substr($builtelement, 0, $pos) . '<table><tbody>' . substr($builtelement, $pos);
}
}
else {
- $builtelement = substr($builtelement, 0, 11) . '<table>' . substr($builtelement, 11);
+ $builtelement = substr($builtelement, 0, 11) . '<table><tbody>' . substr($builtelement, 11);
}
- $builtelement = substr($builtelement, 0, -12) . '</table></fieldset>';
+ $builtelement = substr($builtelement, 0, -12) . '</tbody></table></fieldset>';
$result = "\t<tr>\n\t\t<td colspan=\"2\">";
$result .= $builtelement;
@@ -83,7 +83,13 @@
// Contextual help
if (!empty($rawelement['help'])) {
- $result .= ' <span class="help"><a href="#" title="' . Pieform::hsc($rawelement['help']) . '">?</a></span>';
+ $function = $form->get_property('helpcallback');
+ if (function_exists($function)) {
+ $result .= $function($form, $rawelement);
+ }
+ else {
+ $result .= ' <span class="help"><a href="#" title="' . Pieform::hsc($rawelement['help']) . '">?</a></span>';
+ }
}
$result .= "</td>\n\t</tr>\n";
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ora...@us...> - 2008-02-26 03:28:16
|
Revision: 289
http://pieforms.svn.sourceforge.net/pieforms/?rev=289&view=rev
Author: oracleshinoda
Date: 2008-02-25 19:28:20 -0800 (Mon, 25 Feb 2008)
Log Message:
-----------
Allow the description line to be output as two cells rather than just one with a colspan if the user wants.
Modified Paths:
--------------
pieforms-php5/trunk/src/pieform/renderers/table.php
Modified: pieforms-php5/trunk/src/pieform/renderers/table.php
===================================================================
--- pieforms-php5/trunk/src/pieform/renderers/table.php 2008-01-30 02:33:29 UTC (rev 288)
+++ pieforms-php5/trunk/src/pieform/renderers/table.php 2008-02-26 03:28:20 UTC (rev 289)
@@ -80,7 +80,12 @@
// Description - optional description of the element, or other note that should be visible
// on the form itself (without the user having to hover over contextual help
if ((!$form->has_errors() || $form->get_property('showdescriptiononerror')) && !empty($element['description'])) {
- $result .= "\t<tr>\n\t\t<td colspan=\"2\" class=\"description\">";
+ if ($form->get_property('descriptionintwocells')) {
+ $result .= "\t<tr>\n\t\t<td></td><td class=\"description\">";
+ }
+ else {
+ $result .= "\t<tr>\n\t\t<td colspan=\"2\" class=\"description\">";
+ }
$result .= $element['description'];
$result .= "</td>\n\t</tr>\n";
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X