[Pieforms-commit] SF.net SVN: pieforms:[313] pieforms-php5/trunk/src/pieform/elements

[<ora...@us...>]

Revision: 313
          http://pieforms.svn.sourceforge.net/pieforms/?rev=313&view=rev
Author:   oracleshinoda
Date:     2009-08-06 00:00:47 +0000 (Thu, 06 Aug 2009)

Log Message:
-----------
Only access $global if the form has been submitted. Thanks to Ben Bradshaw

Modified Paths:
--------------
    pieforms-php5/trunk/src/pieform/elements/bytes.php
    pieforms-php5/trunk/src/pieform/elements/checkbox.php
    pieforms-php5/trunk/src/pieform/elements/expiry.php

Modified: pieforms-php5/trunk/src/pieform/elements/bytes.php
===================================================================
--- pieforms-php5/trunk/src/pieform/elements/bytes.php	2009-07-12 22:00:42 UTC (rev 312)
+++ pieforms-php5/trunk/src/pieform/elements/bytes.php	2009-08-06 00:00:47 UTC (rev 313)
@@ -47,7 +47,8 @@
         $bytes = $element['value'];
         $values = pieform_element_bytes_get_bytes_from_bytes($element['value']);
     }
-    else if (isset($global[$element['name']])
+    else if ($form->is_submitted()
+             && isset($global[$element['name']])
              && isset($global[$element['name'] . '_units'])) {
         $values = array('number' => $global[$element['name']],
                         'units'  => $global[$element['name'] . '_units']);

Modified: pieforms-php5/trunk/src/pieform/elements/checkbox.php
===================================================================
--- pieforms-php5/trunk/src/pieform/elements/checkbox.php	2009-07-12 22:00:42 UTC (rev 312)
+++ pieforms-php5/trunk/src/pieform/elements/checkbox.php	2009-08-06 00:00:47 UTC (rev 313)
@@ -37,7 +37,7 @@
         $checked = true;
     }
     $global = ($form->get_property('method') == 'get') ? $_GET : $_POST;
-    if (isset($global[$element['name']])) {
+    if ($form->is_submitted() && isset($global[$element['name']])) {
         $checked = true;
     }
     else if (!$form->is_submitted() && !empty($element['defaultvalue'])) {

Modified: pieforms-php5/trunk/src/pieform/elements/expiry.php
===================================================================
--- pieforms-php5/trunk/src/pieform/elements/expiry.php	2009-07-12 22:00:42 UTC (rev 312)
+++ pieforms-php5/trunk/src/pieform/elements/expiry.php	2009-08-06 00:00:47 UTC (rev 313)
@@ -47,7 +47,8 @@
         $seconds = $element['value'];
         $values = pieform_element_expiry_get_expiry_from_seconds($element['value']);
     }
-    else if (isset($global[$element['name']])
+    else if ($form->is_submitted()
+             && isset($global[$element['name']])
              && isset($global[$element['name'] . '_units'])) {
         $values = array('number' => $global[$element['name']],
                         'units'  => $global[$element['name'] . '_units']);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.