[Pieforms-commit] SF.net SVN: pieforms: [5] pieforms/src/pieform/elements/button.php

[<ora...@us...>]

Revision: 5
          http://svn.sourceforge.net/pieforms/?rev=5&view=rev
Author:   oracleshinoda
Date:     2006-11-18 01:51:57 -0800 (Sat, 18 Nov 2006)

Log Message:
-----------
Force buttons to have a value set, rather than potientially getting the value from the request. Use Pieform::hsc.

Modified Paths:
--------------
    pieforms/src/pieform/elements/button.php

Modified: pieforms/src/pieform/elements/button.php
===================================================================
--- pieforms/src/pieform/elements/button.php	2006-11-18 09:39:46 UTC (rev 4)
+++ pieforms/src/pieform/elements/button.php	2006-11-18 09:51:57 UTC (rev 5)
@@ -26,15 +26,20 @@
 
 /**
  * Renders an <input type="button"> element. 
+ *
+ * The element must have the 'value' field set.
  * 
  * @param array $element The element to render
  * @param Pieform  $form The form to render the element for
  * @return string        The HTML for the element
  */
 function pieform_render_button($element, Pieform $form) {
+    if (!isset($element['value'])) {
+        throw new PieformException('Button elements must have a value');
+    }
     return '<input type="button"'
         . Pieform::element_attributes($element)
-        . ' value="' . hsc($form->get_value($element)) . '">';
+        . ' value="' . Pieform::hsc($element['value']) . '">';
 }
 
 ?>


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.