Patches item #1209197, was opened at 2005-05-26 10:58
Message generated for change (Comment added) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1209197&group_id=235
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Evan Schoenberg (evands)
Assigned to: Mark Doliner (thekingant)
Summary: Consistency in text of authorization request dialogs
Initial Comment:
There are, as of 1.3.0 and HEAD, three different ways in which
authorization request windows are phrased:
MSN: The user %s wants to add %s to his or her buddy list.
Jabber: The user %s wants to add you to their buddy list
ICQ: The user %u wants to add you to their buddy list for the
following reason:\n%s
The MSN one is most helpful, including the relevant account in the
text. This patch makes Jabber's authorization request the same as
MSN's (showing the account and reducing by one the number of
unique strings which need to be translated) and brings ICQ's in line
with the other two to include the account information (The user %s
wants to add %s to their buddy list for the following reason:\n%s)
It'd be even better if these three went through a common core
method which passed the UI the actual GaimAccount, since right
now the string has to be parsed to figure that information out and it's
not perfectly reliable since there is no protocol information included
(Jabber, MSN, ICQ)... but this is at least better :)
----------------------------------------------------------------------
>Comment By: Mark Doliner (thekingant)
Date: 2005-05-31 19:04
Message:
Logged In: YES
user_id=20979
I applied this to HEAD. Thanks
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1209197&group_id=235
|
