Patches item #1185449, was opened at 2005-04-18 17:12
Message generated for change (Settings changed) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1185449&group_id=235
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Richard Laager (rlaager)
>Assigned to: Mark Doliner (thekingant)
Summary: Conversation History Saving Fix
Initial Comment:
As the comment in gtkconv.c says, saving a duplicate copy
of the entire conversation is completely bogus. Saving a
copy of a conversation is a UI thing (if the UI is only showing
the last five messages, for example, that's all the user
would expect to be saved). Therefore, there's no problem
having the UI save its own buffer. The GTK+ UI is already
doing this with the imhtml object. This patch removes the
history from GaimConversation and uses the buffer in the
imhtml object when saving a conversation.
It also adds <html>, <head>, <title>, and <body> tags to
the file to make it a bit more valid.
This patch is extremely likely to break plugins because it
changes the size of the GaimConversation struct. As such,
if this is committed, I recommend the developers recompile
non-default plugins. This broke Gaim-Encryption for me,
hence the warning.
----------------------------------------------------------------------
Comment By: Richard Laager (rlaager)
Date: 2005-04-18 17:45
Message:
Logged In: YES
user_id=156487
Forgot to mention, this needs a ChangeLog.API entry for the
removal of gaim_conversation_set_history and
gaim_conversation_get_history.
----------------------------------------------------------------------
Comment By: Richard Laager (rlaager)
Date: 2005-04-18 17:22
Message:
Logged In: YES
user_id=156487
We should also escape the resulting filename. Here's a new
patch that also does that.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1185449&group_id=235
|
