From: SourceForge.net <no...@so...> - 2005-02-11 22:41:38
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Nobody/Anonymous (nobody) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 00:53:17
|
Patches item #1121104, was opened at 2005-02-11 17:41 Message generated for change (Settings changed) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) >Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-03-08 00:50:04
|
Patches item #1121104, was opened at 2005-02-11 16:41 Message generated for change (Comment added) made by marv_sf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-07 18:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-03-08 01:36:54
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-03-09 00:02:14
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 11:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-03-09 02:12:50
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 13:12 Message: Logged In: YES user_id=407708 Ok, here's an initial 1.x patch. Comments welcome. I've done *some* tidying up. More comments welcome. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 11:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-03-17 03:25:52
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-17 14:25 Message: Logged In: YES user_id=407708 It would appear there's something deeply wrong with privacy, where 0 = 1. Go figure. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 13:12 Message: Logged In: YES user_id=407708 Ok, here's an initial 1.x patch. Comments welcome. I've done *some* tidying up. More comments welcome. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 11:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-03-25 06:57:23
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-25 17:57 Message: Logged In: YES user_id=407708 This patch missed checking privacy for audibles. Next patch will update this. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-17 14:25 Message: Logged In: YES user_id=407708 It would appear there's something deeply wrong with privacy, where 0 = 1. Go figure. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 13:12 Message: Logged In: YES user_id=407708 Ok, here's an initial 1.x patch. Comments welcome. I've done *some* tidying up. More comments welcome. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 11:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-03-27 02:09:55
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-27 12:09 Message: Logged In: YES user_id=407708 Update to previous patch. MUST BE APPLIED AFTER PREVIOUS TWO PATCHES 1. At the suggestion of marv, rename function to yahoo_privacy_check 2. Remove doc reference in yahoo.h for a feature that didn't make the final cut 3. Add support for blocking audibles. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-25 17:57 Message: Logged In: YES user_id=407708 This patch missed checking privacy for audibles. Next patch will update this. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-17 14:25 Message: Logged In: YES user_id=407708 It would appear there's something deeply wrong with privacy, where 0 = 1. Go figure. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 13:12 Message: Logged In: YES user_id=407708 Ok, here's an initial 1.x patch. Comments welcome. I've done *some* tidying up. More comments welcome. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 11:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-04-24 21:57:01
|
Patches item #1121104, was opened at 2005-02-11 17:41 Message generated for change (Settings changed) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-04-24 17:56 Message: Logged In: YES user_id=20979 I applied this to oldstatus. We're definitely missing some of this stuff from head. I don't know what. Could you look through your changes and create a new patch for head of the stuff that is already in oldstatus? ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-26 21:09 Message: Logged In: YES user_id=407708 Update to previous patch. MUST BE APPLIED AFTER PREVIOUS TWO PATCHES 1. At the suggestion of marv, rename function to yahoo_privacy_check 2. Remove doc reference in yahoo.h for a feature that didn't make the final cut 3. Add support for blocking audibles. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-25 01:57 Message: Logged In: YES user_id=407708 This patch missed checking privacy for audibles. Next patch will update this. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-16 22:25 Message: Logged In: YES user_id=407708 It would appear there's something deeply wrong with privacy, where 0 = 1. Go figure. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 21:12 Message: Logged In: YES user_id=407708 Ok, here's an initial 1.x patch. Comments welcome. I've done *some* tidying up. More comments welcome. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 19:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-07 20:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-07 19:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-04-24 22:11:15
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-04-25 08:11 Message: Logged In: YES user_id=407708 When I wrote these, I couldn't compile head. I'll do it in the next few days, along with a mini-audit of other changes in yahoo prpl. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-04-25 07:56 Message: Logged In: YES user_id=20979 I applied this to oldstatus. We're definitely missing some of this stuff from head. I don't know what. Could you look through your changes and create a new patch for head of the stuff that is already in oldstatus? ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-27 12:09 Message: Logged In: YES user_id=407708 Update to previous patch. MUST BE APPLIED AFTER PREVIOUS TWO PATCHES 1. At the suggestion of marv, rename function to yahoo_privacy_check 2. Remove doc reference in yahoo.h for a feature that didn't make the final cut 3. Add support for blocking audibles. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-25 17:57 Message: Logged In: YES user_id=407708 This patch missed checking privacy for audibles. Next patch will update this. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-17 14:25 Message: Logged In: YES user_id=407708 It would appear there's something deeply wrong with privacy, where 0 = 1. Go figure. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 13:12 Message: Logged In: YES user_id=407708 Ok, here's an initial 1.x patch. Comments welcome. I've done *some* tidying up. More comments welcome. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 11:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-04-24 22:43:15
|
Patches item #1121104, was opened at 2005-02-11 17:41 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-04-24 18:43 Message: Logged In: YES user_id=20979 Rock on ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-04-24 18:11 Message: Logged In: YES user_id=407708 When I wrote these, I couldn't compile head. I'll do it in the next few days, along with a mini-audit of other changes in yahoo prpl. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-04-24 17:56 Message: Logged In: YES user_id=20979 I applied this to oldstatus. We're definitely missing some of this stuff from head. I don't know what. Could you look through your changes and create a new patch for head of the stuff that is already in oldstatus? ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-26 21:09 Message: Logged In: YES user_id=407708 Update to previous patch. MUST BE APPLIED AFTER PREVIOUS TWO PATCHES 1. At the suggestion of marv, rename function to yahoo_privacy_check 2. Remove doc reference in yahoo.h for a feature that didn't make the final cut 3. Add support for blocking audibles. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-25 01:57 Message: Logged In: YES user_id=407708 This patch missed checking privacy for audibles. Next patch will update this. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-16 22:25 Message: Logged In: YES user_id=407708 It would appear there's something deeply wrong with privacy, where 0 = 1. Go figure. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 21:12 Message: Logged In: YES user_id=407708 Ok, here's an initial 1.x patch. Comments welcome. I've done *some* tidying up. More comments welcome. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 19:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-07 20:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-07 19:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-05-15 00:44:25
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-05-15 10:44 Message: Logged In: YES user_id=407708 Additional fix in 1.x patch 1202156 ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-04-25 08:43 Message: Logged In: YES user_id=20979 Rock on ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-04-25 08:11 Message: Logged In: YES user_id=407708 When I wrote these, I couldn't compile head. I'll do it in the next few days, along with a mini-audit of other changes in yahoo prpl. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-04-25 07:56 Message: Logged In: YES user_id=20979 I applied this to oldstatus. We're definitely missing some of this stuff from head. I don't know what. Could you look through your changes and create a new patch for head of the stuff that is already in oldstatus? ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-27 12:09 Message: Logged In: YES user_id=407708 Update to previous patch. MUST BE APPLIED AFTER PREVIOUS TWO PATCHES 1. At the suggestion of marv, rename function to yahoo_privacy_check 2. Remove doc reference in yahoo.h for a feature that didn't make the final cut 3. Add support for blocking audibles. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-25 17:57 Message: Logged In: YES user_id=407708 This patch missed checking privacy for audibles. Next patch will update this. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-17 14:25 Message: Logged In: YES user_id=407708 It would appear there's something deeply wrong with privacy, where 0 = 1. Go figure. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 13:12 Message: Logged In: YES user_id=407708 Ok, here's an initial 1.x patch. Comments welcome. I've done *some* tidying up. More comments welcome. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 11:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |