From: SourceForge.net <no...@so...> - 2005-02-14 22:11:40
|
Patches item #1122730, was opened at 2005-02-14 23:11 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Nobody/Anonymous (nobody) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 00:55:50
|
Patches item #1122730, was opened at 2005-02-14 17:11 Message generated for change (Settings changed) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) >Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 04:25:16
|
Patches item #1122730, was opened at 2005-02-14 17:11 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-02-14 23:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 11:05:58
|
Patches item #1122730, was opened at 2005-02-14 23:11 Message generated for change (Comment added) made by bookeldor You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: BookeldOr (bookeldor) Date: 2005-02-15 12:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 05:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 13:08:36
|
Patches item #1122730, was opened at 2005-02-14 17:11 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-02-15 08:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 06:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-14 23:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 13:09:49
|
Patches item #1122730, was opened at 2005-02-14 17:11 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-02-15 08:09 Message: Logged In: YES user_id=20979 Oh, and I asked about head/oldstatus because I seem to remember us changing the smileys in head to use a menu instead of a dialog, or something similar. I might not be remembering that correctly, though. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 08:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 06:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-14 23:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 15:51:25
|
Patches item #1122730, was opened at 2005-02-14 23:11 Message generated for change (Comment added) made by bookeldor You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:09 Message: Logged In: YES user_id=20979 Oh, and I asked about head/oldstatus because I seem to remember us changing the smileys in head to use a menu instead of a dialog, or something similar. I might not be remembering that correctly, though. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 12:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 05:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 15:52:02
|
Patches item #1122730, was opened at 2005-02-14 23:11 Message generated for change (Comment added) made by bookeldor You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:09 Message: Logged In: YES user_id=20979 Oh, and I asked about head/oldstatus because I seem to remember us changing the smileys in head to use a menu instead of a dialog, or something similar. I might not be remembering that correctly, though. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 12:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 05:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 15:56:55
|
Patches item #1122730, was opened at 2005-02-14 23:11 Message generated for change (Comment added) made by bookeldor You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:56 Message: Logged In: YES user_id=1219198 huh i did not pay attention but the popup stays opened when clicking on an icon (until it is closed with X button) after giving a try, i do like this behaviour wich permits adding multiple icons in a text easily but it may not be obvious (?) ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:09 Message: Logged In: YES user_id=20979 Oh, and I asked about head/oldstatus because I seem to remember us changing the smileys in head to use a menu instead of a dialog, or something similar. I might not be remembering that correctly, though. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 12:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 05:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-15 23:56:48
|
Patches item #1122730, was opened at 2005-02-14 17:11 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-02-15 18:56 Message: Logged In: YES user_id=20979 I'm not married to the menu. I think it's probably better to have icons that don't scrawl all over the screen than to have a mildly pretty interface. I DO think the dialog should close after selecting a smiley, though. I think people generally only use one smiley at a time (or, they SHOULD only use one smiley at a time, anyway :-) ). ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 10:56 Message: Logged In: YES user_id=1219198 huh i did not pay attention but the popup stays opened when clicking on an icon (until it is closed with X button) after giving a try, i do like this behaviour wich permits adding multiple icons in a text easily but it may not be obvious (?) ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 10:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 10:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 08:09 Message: Logged In: YES user_id=20979 Oh, and I asked about head/oldstatus because I seem to remember us changing the smileys in head to use a menu instead of a dialog, or something similar. I might not be remembering that correctly, though. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 08:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 06:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-14 23:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-02-16 17:16:54
|
Patches item #1122730, was opened at 2005-02-14 23:11 Message generated for change (Comment added) made by bookeldor You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: BookeldOr (bookeldor) Date: 2005-02-16 18:16 Message: Logged In: YES user_id=1219198 done. I've uploaded the last patch: it keeps order and closes the popup. And i've tested the menu code at little screen res, it's unuseable with this theme >_<. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-16 00:56 Message: Logged In: YES user_id=20979 I'm not married to the menu. I think it's probably better to have icons that don't scrawl all over the screen than to have a mildly pretty interface. I DO think the dialog should close after selecting a smiley, though. I think people generally only use one smiley at a time (or, they SHOULD only use one smiley at a time, anyway :-) ). ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:56 Message: Logged In: YES user_id=1219198 huh i did not pay attention but the popup stays opened when clicking on an icon (until it is closed with X button) after giving a try, i do like this behaviour wich permits adding multiple icons in a text easily but it may not be obvious (?) ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:09 Message: Logged In: YES user_id=20979 Oh, and I asked about head/oldstatus because I seem to remember us changing the smileys in head to use a menu instead of a dialog, or something similar. I might not be remembering that correctly, though. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 12:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 05:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-04-26 02:31:22
|
Patches item #1122730, was opened at 2005-02-14 17:11 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-04-25 22:31 Message: Logged In: YES user_id=20979 It looks like this does the same thing as the current smiley selector in CVS head... am I missing something? I kind of forgot where we left off. A screen shot of the differences between the old and the new version would be nice... ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-16 12:16 Message: Logged In: YES user_id=1219198 done. I've uploaded the last patch: it keeps order and closes the popup. And i've tested the menu code at little screen res, it's unuseable with this theme >_<. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 18:56 Message: Logged In: YES user_id=20979 I'm not married to the menu. I think it's probably better to have icons that don't scrawl all over the screen than to have a mildly pretty interface. I DO think the dialog should close after selecting a smiley, though. I think people generally only use one smiley at a time (or, they SHOULD only use one smiley at a time, anyway :-) ). ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 10:56 Message: Logged In: YES user_id=1219198 huh i did not pay attention but the popup stays opened when clicking on an icon (until it is closed with X button) after giving a try, i do like this behaviour wich permits adding multiple icons in a text easily but it may not be obvious (?) ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 10:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 10:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 08:09 Message: Logged In: YES user_id=20979 Oh, and I asked about head/oldstatus because I seem to remember us changing the smileys in head to use a menu instead of a dialog, or something similar. I might not be remembering that correctly, though. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 08:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 06:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-14 23:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-04-27 12:21:31
|
Patches item #1122730, was opened at 2005-02-14 23:11 Message generated for change (Comment added) made by bookeldor You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: BookeldOr (bookeldor) Assigned to: Tim Ringenbach (marv_sf) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: BookeldOr (bookeldor) Date: 2005-04-27 14:21 Message: Logged In: YES user_id=1219198 main differences were: - use of a popup window which allows at least to move it when is larger than the screen - number of smileys on a line is calculated to fill better than a fixed number, reducing the number of lines, and so, window's height. i think that's all :) ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-04-26 04:31 Message: Logged In: YES user_id=20979 It looks like this does the same thing as the current smiley selector in CVS head... am I missing something? I kind of forgot where we left off. A screen shot of the differences between the old and the new version would be nice... ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-16 18:16 Message: Logged In: YES user_id=1219198 done. I've uploaded the last patch: it keeps order and closes the popup. And i've tested the menu code at little screen res, it's unuseable with this theme >_<. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-16 00:56 Message: Logged In: YES user_id=20979 I'm not married to the menu. I think it's probably better to have icons that don't scrawl all over the screen than to have a mildly pretty interface. I DO think the dialog should close after selecting a smiley, though. I think people generally only use one smiley at a time (or, they SHOULD only use one smiley at a time, anyway :-) ). ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:56 Message: Logged In: YES user_id=1219198 huh i did not pay attention but the popup stays opened when clicking on an icon (until it is closed with X button) after giving a try, i do like this behaviour wich permits adding multiple icons in a text easily but it may not be obvious (?) ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 16:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:09 Message: Logged In: YES user_id=20979 Oh, and I asked about head/oldstatus because I seem to remember us changing the smileys in head to use a menu instead of a dialog, or something similar. I might not be remembering that correctly, though. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 14:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 12:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 05:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |
From: SourceForge.net <no...@so...> - 2005-05-03 01:28:51
|
Patches item #1122730, was opened at 2005-02-14 17:11 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: BookeldOr (bookeldor) >Assigned to: Mark Doliner (thekingant) Summary: compact placing in smiley popup Initial Comment: there was a problem with themes containing smileys of different sizes: all buttons had the same size: the one of the biggest. preview of the old method with an example theme: http://img208.exs.cx/img208/1900/gaimsmilayspopupold6lp.jpg instead of packing all in a table, it fills hboxes packed in a vbox an option in the gtkprefs.c defines two behaviours: 1. compact: sorts smileys by height and sets line width to (total width of all smileys)/sqrt(number of smileys) and fills each line until it's full, preview: http://img148.exs.cx/img148/2654/gaimsmilayspopupcompact7kd.jpg 2. not compact: order of the theme file is respected and the number of smileys in a row is fixed and equals the number of rows : sqrt(number of smileys) nevertheless, each line is independent in height and placement of smileys so it is better than old method with a table. preview: http://img148.exs.cx/img148/1983/gaimsmilayspopupnotcompact3kf.jpg ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-05-02 21:28 Message: Logged In: YES user_id=20979 Alright, committed to HEAD. Let me know if you have a real name you'd like me to add to the COPYRIGHT file. Thanks! ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-04-27 08:21 Message: Logged In: YES user_id=1219198 main differences were: - use of a popup window which allows at least to move it when is larger than the screen - number of smileys on a line is calculated to fill better than a fixed number, reducing the number of lines, and so, window's height. i think that's all :) ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-04-25 22:31 Message: Logged In: YES user_id=20979 It looks like this does the same thing as the current smiley selector in CVS head... am I missing something? I kind of forgot where we left off. A screen shot of the differences between the old and the new version would be nice... ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-16 12:16 Message: Logged In: YES user_id=1219198 done. I've uploaded the last patch: it keeps order and closes the popup. And i've tested the menu code at little screen res, it's unuseable with this theme >_<. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 18:56 Message: Logged In: YES user_id=20979 I'm not married to the menu. I think it's probably better to have icons that don't scrawl all over the screen than to have a mildly pretty interface. I DO think the dialog should close after selecting a smiley, though. I think people generally only use one smiley at a time (or, they SHOULD only use one smiley at a time, anyway :-) ). ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 10:56 Message: Logged In: YES user_id=1219198 huh i did not pay attention but the popup stays opened when clicking on an icon (until it is closed with X button) after giving a try, i do like this behaviour wich permits adding multiple icons in a text easily but it may not be obvious (?) ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 10:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 10:51 Message: Logged In: YES user_id=1219198 :,-( my method is unuseable with menus (to be compact, number of items in a line must not be fixed and columns width must change, this is not possible - with my gtk2 knowledge - with a menu) I'll send a diff (it keeps the theme order) but it deletes the menu code to restore the popup code with my enhancements. oh and my popup is still really more compact than menu with my example theme. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 08:09 Message: Logged In: YES user_id=20979 Oh, and I asked about head/oldstatus because I seem to remember us changing the smileys in head to use a menu instead of a dialog, or something similar. I might not be remembering that correctly, though. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-15 08:08 Message: Logged In: YES user_id=20979 Whatever you think is best. Both your screen shots looked really good. I DO think it's a good idea to maintain the order. ---------------------------------------------------------------------- Comment By: BookeldOr (bookeldor) Date: 2005-02-15 06:05 Message: Logged In: YES user_id=1219198 Sure I can, This patch was for last stable version, i'll get cvs version and adapt it But i propose a new behaviour: keep order of theme but without fixed number of smileys per line. nb: if smileys have same size, as in current default themes, nothing is changed. and thanks for this UI doc, i've bookmarked it ^^ ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-02-14 23:25 Message: Logged In: YES user_id=20979 This patch is against CVS head, right? We're not going to add a preference for that. See "The Question of Preferences" at http://www106.pair.com/rhp/free-software-ui.html for our reasons. Do you think you could modify the patch to always do #2? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1122730&group_id=235 |