pidgin-devel

Re: [Gaim-devel] libgaim strings

[Sean E. <sea...@gm...>]

On 2/10/07, Evan Schoenberg <ev...@ad...> wrote:
> Sean asked me to review the strings Adium is currently parsing
> manually.  Below is a nearly complete list (I may have missed a
> couple), with comments where appropriate.  If we could fix up
> libgaim not to ever require this sort of parsing, its translations
> could be used, which would be great.
>
> Cheers,
> Evan
> ----
> The following strings are ignored:
> ----
> primary string contains:
> Already there - MSN throws this, and I'm not sure why anyone would
> ever care
> Group not removed - I don't think users ever expect that deleting a
> group without some accounts connected would delete the contacts on
> that account; in fact I bet people would be upset if  it did.
>
> secondary string contains:
> Could not add the buddy 1 for an unknown reason
>         Oh really?  I didn't even know I was trying to add buddy 1! :)
>
> Your screen name is currently formatted as follows
>      We don't have the "format screen name action" but instead use
> whatever formatting the user types in the accounts dialogue.  When
> AIM signs on, the formatting is set; we suppress the "good work"
> dialogue.

With the exception of losing the ability to reformat your screenname
while logged in, this seems like a pretty cool thing to do.

> Error reading from Switchboard server
>      Unhelpful, and we can't do anything about it. MSN just sucks.
>
> 0x001a: Unknown error
>      Yeah, it's unknown.
>
> Not supported by host
>      AIM throws this if you try to do formatting when logged in with
> a .mac name.  I think we avoid trying that in the first place... so
> this may be superfluous in the list
>
> Not logged in
>      Is this still shown as a popup?  We display our own in-chat
> message if you try to send a message while a user isn't available.

For a while now, we've had a "conversation error" function that will
show the error in the conversation if said conversation exists, but
show it in a gaim_notify_error dialog otherwise. So this will still
come in to gaim_notify_error in some cases (e.g. trying to get the AIM
profile of an online user.) Does Adium create new conversation windows
in that case?

> Your buddy list was downloaded from the server.
> Your buddy list was stored on the server.
>      These two are from Gadu-Gadu; having to manually upload/download
> the buddy list is silly, so Adium does so automatically (upload after
> a buddy change like a move or add, download on connect).

Was Bartosz going to change this behavior?

> Your contact is using Windows Live
>      Right now, Yahoo doesn't have MSN support.  Every time a Yahoo
> account connects, it gets told to go download the official Yahoo
> client to talk to MSN folk. Ick.  I prefer silence on the matter :)
>
>
> ----
> Problematic strings:

Because of the string freeze, we won't be able to change these until
after 2.0.0.

> "Reply too big" sounds awkward. I prefer "Your message was too big"
> "In local permit/deny" is odd... when would you ever not be able to
> send a message because the person was in your permit list? I prefer
> "The other user is in your deny list"
> "Too evil" is odd... it's called a warning level :)
> "User temporarily unavailable" isn't a complete statement...we use
> "The other user is temporarily unavailable". Similarly for other
> error messages where possible.

These all come from OSCAR:
static char *msgerrreason[] = {
        N_("Invalid error"),
        N_("Invalid SNAC"),
        N_("Rate to host"),
        N_("Rate to client"),
        N_("Not logged in"),
        N_("Service unavailable"),
        N_("Service not defined"),
        N_("Obsolete SNAC"),
        N_("Not supported by host"),
        N_("Not supported by client"),
        N_("Refused by client"),
        N_("Reply too big"),
        N_("Responses lost"),
        N_("Request denied"),
        N_("Busted SNAC payload"),
        N_("Insufficient rights"),
        N_("In local permit/deny"),
        N_("Too evil (sender)"),
        N_("Too evil (receiver)"),
        N_("User temporarily unavailable"),
        N_("No match"),
        N_("List overflow"),
        N_("Request ambiguous"),
        N_("Queue full"),
        N_("Not while on AOL")
};

I don't think any of those qualifies as a decent error message.
However, I do have to point out that the feature is called "evil," and
I guess the AOL marketing people wigged out and wanted to call it
"warning" instead. Of course, we should call it "warning" too.

> a couple hacks related to us just not having gaim_request_fields()
> and gaim_notify_search_results(), like custom handling of the
> Sametime "ambiguous user ID" window. As far as search results, I
> think Gaim's is interactive?
> ---
> "wants to send you" <-- gaim_xfer_ask_recv() sends this.. I don't
> understand why it's not going through the normal xfer ui ops
> ---
> incoming via request_file(), the Sametime export/import is weird...
> we want to immediately display a save/open panel and then trigger the
> callback directly, so "Sametime", "Export", and "Import" are checked
> for.
> ----
> Account actions:
> The 3 buddylist account actions for gadu-gadu are suppressed by name:
>      Download buddylist from Server
>      Upload buddylist to Server
>      Delete buddylist from Server
> AIM
>      Set User Info... is suppressed because it are handled via
> integrated UI rather than separate popup request dialogues
>      The (URL) after actions seems odd to me... why should the user
> care if they'll be directed to a web page or not?

Because launching a web browser isn't necessary cheap?

> Yahoo:
>      Why is there an "Add Buddy" item here and nowhere else?  This is
> suppressed in Adium; the contextual menu for *any* buddy not on the
> buddy list already has a similar item without the account having to
> add one.
> -----
> Contact actions:
> MSN: "Initiate Chat" is ambiguous; it should be "Initiate Multiuser
> Chat" or "Initiate Group Chat"

In Gaim parlance, "chat" is synonymous with "multiuser chat" or "group chat."

> AIM: "Edit buddy comment" is the same situation as "Set User Info..."
> in actions above.
> -----
> Disconnect messages:
> we want to handle "invalid password" across all accounts by clearing
> the saved password and prompting for it again... that requires a
> string parse at present.

I think Rlaager was doing something like this.

> AIM tells us when a screenname isn't valid; we can handle that error
> message with more verbosity and therefore more helpfulness.

That's a dangerous "therefore" ;)

> This is
> what Adium shows at present: "The screen name you entered is not
> registered. Check to ensure you typed it correctly. If it is a new
> name, you must register it at www.aim.com before you can use it."

Re: [Gaim-devel] libgaim strings

[Evan S. <ev...@ad...>]

On Feb 11, 2007, at 6:32 PM, Sean Egan wrote:

> For a while now, we've had a "conversation error" function that will
> show the error in the conversation if said conversation exists, but
> show it in a gaim_notify_error dialog otherwise. So this will still
> come in to gaim_notify_error in some cases (e.g. trying to get the AIM
> profile of an online user.) Does Adium create new conversation windows
> in that case?

Trying to get the AIM profile of an offline user (I assume you meant  
offline, not online) fails silently since we suppress the dialogue.   
New conversation windows wouldn't be created; a separate dialogue  
would be shown. By  the time it hits the notify_message() callback,  
there isn't enough data to put something into a conversation window  
-- the core has handled trying that already.

>> Your buddy list was downloaded from the server.
>> Your buddy list was stored on the server.
>>      These two are from Gadu-Gadu; having to manually upload/download
>> the buddy list is silly, so Adium does so automatically (upload after
>> a buddy change like a move or add, download on connect).
>
> Was Bartosz going to change this behavior?
I opened a thread discussing this behavior a while back (December  
'06).  Bartosz initially felt that these behaviors were too important  
to be automatic, and that rather user intervention should be  
explicitly required for either to occur; after discussion, he  
suggested difference detection, similar to how the MSN protocol  
handles it.


> Because of the string freeze, we won't be able to change these until
> after 2.0.0.
For sure :)

>
> <bad error messages>
> These all come from OSCAR:
> I don't think any of those qualifies as a decent error message.
Indeed.  So no objection to rewriting them after 2.0.0?

> However, I do have to point out that the feature is called "evil," and
> I guess the AOL marketing people wigged out and wanted to call it
> "warning" instead. Of course, we should call it "warning" too.
Sounds like a very probably story of what happened at AOL corporate :)

>>      The (URL) after actions seems odd to me... why should the user
>> care if they'll be directed to a web page or not?
>
> Because launching a web browser isn't necessary cheap?
Worksforme.  My web browser is always launched, so I just didn't  
think about it.  I'm not heartbroken for (URL) to be there.... though  
perhaps something more user friendly like (Web) or (Web page) would  
be better.  It's asking a couple steps of reasoning for (URL) to be  
understood: the user has to first recognize that (URL) is there, then  
reason that this indicates that they are about to click on a URL,  
then reason that Gaim isn't going to display the resulting web page  
directly but rather that a web site is going to be loaded in a  
browser window.

>> Yahoo:
>>      Why is there an "Add Buddy" item here and nowhere else?  This is
>> suppressed in Adium; the contextual menu for *any* buddy not on the
>> buddy list already has a similar item without the account having to
>> add one.
>> -----
>> Contact actions:
>> MSN: "Initiate Chat" is ambiguous; it should be "Initiate Multiuser
>> Chat" or "Initiate Group Chat"
>
> In Gaim parlance, "chat" is synonymous with "multiuser chat" or  
> "group chat."
I see.  It'd be nice for MSN to have the same group chat interface as  
the rest of the prpls, of course, making that option moot, but its  
craziness makes that a bit tough.

>> AIM tells us when a screenname isn't valid; we can handle that error
>> message with more verbosity and therefore more helpfulness.
>>> This is
>>> what Adium shows at present: "The screen name you entered is not
>>> registered. Check to ensure you typed it correctly. If it is a new
>>> name, you must register it at www.aim.com before you can use it."
>
> That's a dangerous "therefore" ;)
:)  In this *particular* case, the verbosity is more helpful.   
Definitely agree that it's not a good general practice.

-Evan

Re: [Gaim-devel] libgaim strings

[Sean E. <sea...@gm...>]

On 2/12/07, Evan Schoenberg <ev...@ad...> wrote:
> Worksforme.  My web browser is always launched, so I just didn't think about
> it.

I said that with a question mark, because it was just my probably
explanation for why it was added. I'm not necessarily defending them
(nor necessarily supporting their removal). Whoever added them (Mark I
presume) can probably chime in on it.

We would need to do *something* about having two "Change Passwords" if
we removed the "URL."

Why *do* we have two "Change Passwords"?

> I see.  It'd be nice for MSN to have the same group chat interface as the
> rest of the prpls, of course, making that option moot, but its craziness
> makes that a bit tough.

What we actually need (and have needed for a very long time) is a
"conference" or "anonymous group chat" feature. Pretty much all our
protocols support the feature, but we hack to turn them into named
chats.