pidgin-devel

[Gaim-devel] Early autodetection of IP address?

[Evan S. <ev...@dr...>]

gaim_core_init() has:

	/*
	 * Call this early on to try to auto-detect our IP address and
	 * hopefully save some time later.
	 */
	gaim_network_get_my_ip(-1);

is there a good reason for this non-lazy determination of IP  
address?  The value is *only* used in file transfers (OSCAR, Jabber,  
IRC, QQ) with the exception of connecting via SIP and Novell.  It  
seems like by the general use case it should be lazy.

-Evan

Re: [Gaim-devel] Early autodetection of IP address?

[Mark D. <ma...@ki...>]

On Sat, 31 Mar 2007 16:29:29 -0400, Evan Schoenberg wrote
> gaim_core_init() has:
> 
> 	/*
> 	 * Call this early on to try to auto-detect our IP address and
> 	 * hopefully save some time later.
> 	 */
> 	gaim_network_get_my_ip(-1);
> 
> is there a good reason for this non-lazy determination of IP  
> address?  The value is *only* used in file transfers (OSCAR, Jabber, 
>  IRC, QQ) with the exception of connecting via SIP and Novell.  It 
>  seems like by the general use case it should be lazy.

gaim_network_get_my_ip() sometimes uses upnp or pmp to determine the external
IP address of your machine.  I think the intent here was for Gaim to perform
those upnp calls in the background so that they don't need to be done while
the user is waiting to send a file to someone.  But if the calls to the upnp
and pmp code are blocking then this is a silly thing to do and it would be
fine to change it to be lazy.

Of course, it would be best if upnp and pmp are non-blocking and Gaim could
talk to your router in the background shortly after startup while your
accounts are merrily logging in.

-Mark

Re: [Gaim-devel] Early autodetection of IP address?

[Daniel A. <dan...@gm...>]

On 4/3/07, Mark Doliner <ma...@ki...> wrote:
>
> Of course, it would be best if upnp and pmp are non-blocking and Gaim
> could
> talk to your router in the background shortly after startup while your
> accounts are merrily logging in.


The upnp stuff is non-blocking.

-D

Re: [Gaim-devel] Early autodetection of IP address?

[Evan S. <ev...@dr...>]

On Apr 3, 2007, at 9:44 AM, Daniel Atallah wrote:

> On 4/3/07, Mark Doliner <ma...@ki...> wrote:
> Of course, it would be best if upnp and pmp are non-blocking and  
> Gaim could
> talk to your router in the background shortly after startup while your
> accounts are merrily logging in.
>
> The upnp stuff is non-blocking.

The majority of upnp is non-blocking, but gaim_upnp_discover() says:
> 	/* TODO: Non-blocking! */
> 	if((hp = gethostbyname(HTTPMU_HOST_ADDRESS)) == NULL) {

and is called by gaim_upnp_get_public_ip() the first time it's used.

The pmp stuff is blocking, though its blocking operations are  
specifically limited to 0.25 seconds in duration (pending being  
nonblocking, which I haven't done any work on yet but will look at  
eventually if someone - preferably someone who has actual experience  
writing nonblocking sockets code - doesn't beat me to it).

For the record, I've never seen a significant delay as a result of  
either block of code... but I noticed that it was being done when I  
was working in network.c and was surprised that the public IP was  
determined long before it was ever needed and might never be used at  
all.

-Evan