From: Tim R. <tim...@co...> - 2005-07-27 00:45:58
|
Could someone please explain to me why this was needed, and what it caused, and what happens without it? --Tim Daniel Atallah wrote: > Update of /cvsroot/gaim/gaim/src/protocols/yahoo > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25199/src/protocols/yahoo > > Modified Files: > yahoo.h > Log Message: > Default yahoo chat roomlist locale to 'us' > > Index: yahoo.h > =================================================================== > RCS file: /cvsroot/gaim/gaim/src/protocols/yahoo/yahoo.h,v > retrieving revision 1.39 > retrieving revision 1.40 > diff -u -d -p -r1.39 -r1.40 > --- yahoo.h 30 Jun 2005 06:50:55 -0000 1.39 > +++ yahoo.h 26 Jul 2005 04:42:53 -0000 1.40 > @@ -34,7 +34,7 @@ > #define YAHOO_XFER_HOST "filetransfer.msg.yahoo.com" > #define YAHOO_XFER_PORT 80 > #define YAHOO_ROOMLIST_URL "http://insider.msg.yahoo.com/ycontent/" > -#define YAHOO_ROOMLIST_LOCALE "" > +#define YAHOO_ROOMLIST_LOCALE "us" > /* really we should get the list of servers from > http://update.messenger.yahoo.co.jp/servers.html */ > #define YAHOOJP_PAGER_HOST "cs.yahoo.co.jp" > |
From: Richard L. <rl...@wi...> - 2005-07-27 01:30:10
|
On Tue, 2005-07-26 at 19:45 -0500, Tim Ringenbach wrote: > Could someone please explain to me why this was needed, and what it > caused, and what happens without it? I haven't verified that this does what it's supposed to do, but here's the idea (from the conversation in #gaim yesterday): If the user doesn't set a chat room locale, they only get the "international" room list. By setting a locale, they also get country- specific chat rooms in the list. Having a default of "us" means U.S. users won't have to configure the locale and will still get localized rooms. Peter proposed that we query the system locale. I believe this would be superior to assuming everyone is in the U.S. In terms of Yahoo chat locales, I think it's safe to assume that most of our users are in the U.S., so I would say that makes U.S. the best choice to hard code as the default unless/until system locale querying code is written. Daniel said in #gaim, "if you see US stuff and you don't want to, you are more likely to look around for a setting, but if you don't get local rooms at all, you are likely to think something is wrong". I think there's some merit to this as well. Richard |
From: Daniel A. <dan...@gm...> - 2005-07-27 01:43:31
|
On 7/26/05, Tim Ringenbach <tim...@co...> wrote: > Could someone please explain to me why this was needed, and what it > caused, and what happens without it? >=20 > --Tim Certainly. The reason it was needed was that without a default locale, it looks like the chat list isn't working correctly, as illustrated by: https://sourceforge.net/tracker/?func=3Ddetail&atid=3D100235&aid=3D1243427&= group_id=3D235 I understand that this is somewhat controversial since it introduces a us-centric default, but at the very least, it restores the previous functionality. There was some discussion last night about possibly defaulting to one of the yahoo chat locales based on system locale, with a fallback to "us" if there isn't a match. I wouldn't be opposed to this in the least, it actually sounds like a good idea to me. The way I see it, and as was discussed in #gaim last night, this change really doesn't hurt anything - as far as I can tell it has a completely additive effect on the list and should hopefully prevent some bug reports. -D |