From: Luke S. <lsc...@us...> - 2005-04-26 02:24:31
|
Sean expressed concerns with this patch, that it makes it harder for him and other color blind people to tell the difference between the green and the blue. he also mentioned a few things we could do to work around that. Someone should look into them. luke On Mon, Apr 25, 2005 at 07:02:49PM -0700, Mark Doliner wrote: > Update of /cvsroot/gaim/gaim/src > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26709 > > Modified Files: > gtkconv.c > Log Message: > sf patch #1189893, from Steven Garrity > "This patch slightly changes the shade of the blue color > of inactive tabs on a group chat when someone uses your > nickname. > > The previous blue was a bit too close to the default > black, so it was difficult to notice. This blue is a > little bit brighter and more staturated. > > Here's a screenshot to show the difference (current > blue in the left column, blue from this patch in the > right column): > http://actsofvolition.com/images/screenshots/gaim/tab-colors.png > > The only thing changes is the HEX for the color, so > this could easily be applied to oldstatus as well." > > > Index: gtkconv.c > =================================================================== > RCS file: /cvsroot/gaim/gaim/src/gtkconv.c,v > retrieving revision 1.545 > retrieving revision 1.546 > diff -u -d -p -r1.545 -r1.546 > --- gtkconv.c 24 Apr 2005 21:26:33 -0000 1.545 > +++ gtkconv.c 26 Apr 2005 02:02:43 -0000 1.546 > @@ -5358,7 +5358,7 @@ gaim_gtkconv_updated(GaimConversation *c > } > else if (gaim_conversation_get_unseen(conv) == GAIM_UNSEEN_NICK) > { > - strcpy(color, "#314E6C"); > + strcpy(color, "#0D4E91"); > } > else if (gaim_conversation_get_unseen(conv) == GAIM_UNSEEN_TEXT) > { > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > Gaim-commits mailing list > Gai...@li... > https://lists.sourceforge.net/lists/listinfo/gaim-commits |
From: Steven G. <ste...@si...> - 2005-04-26 02:44:37
|
Luke Schierer wrote: > Sean expressed concerns with this patch, that it makes it harder for > him and other color blind people to tell the difference between the > green and the blue. he also mentioned a few things we could do to > work around that. Someone should look into them. My understanding of Sean's comments where that the use of only color was insufficient in the tab titles, and that his trouble with the green color was not with the blue in this patch, but with the grey [1]: > Have you looked at the grey tab color? I can't tell the > difference between that and the green without really trying. Sean, can you clarify? Thanks, Steven Garrity [1] http://sourceforge.net/tracker/index.php?func=detail&aid=1189893&group_id=235&atid=300235 |
From: Peter L. <spa...@si...> - 2005-04-26 02:47:56
|
Luke Schierer wrote: >Sean expressed concerns with this patch, that it makes it harder for >him and other color blind people to tell the difference between the >green and the blue. he also mentioned a few things we could do to >work around that. Someone should look into them. > >luke > > Last time I brought up the comments re: colour blindness etc., I clearly remember someone of import (maybe even Sean) telling me that's what themes were for. Is that the 'things' you refer to? Pete. |
From: Martin O. <mar...@ma...> - 2005-04-26 19:09:47
|
Could such colors ever exist among some GTK-theme parameters? In case not, prefs.xml is the only place and if that's the option - UI to change color preferences personally would very much be appreciated by me at least. Similar color-preferences exist in X-Chat even for ex. Luke Schierer wrote: > Sean expressed concerns with this patch, that it makes it harder for > him and other color blind people to tell the difference between the > green and the blue. he also mentioned a few things we could do to > work around that. Someone should look into them. > > luke > > On Mon, Apr 25, 2005 at 07:02:49PM -0700, Mark Doliner wrote: > >>Update of /cvsroot/gaim/gaim/src >>In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26709 >> >>Modified Files: >> gtkconv.c >>Log Message: >>sf patch #1189893, from Steven Garrity >>"This patch slightly changes the shade of the blue color >>of inactive tabs on a group chat when someone uses your >>nickname. >> >>The previous blue was a bit too close to the default >>black, so it was difficult to notice. This blue is a >>little bit brighter and more staturated. >> >>Here's a screenshot to show the difference (current >>blue in the left column, blue from this patch in the >>right column): >>http://actsofvolition.com/images/screenshots/gaim/tab-colors.png >> >>The only thing changes is the HEX for the color, so >>this could easily be applied to oldstatus as well." >> >> >>Index: gtkconv.c >>=================================================================== >>RCS file: /cvsroot/gaim/gaim/src/gtkconv.c,v >>retrieving revision 1.545 >>retrieving revision 1.546 >>diff -u -d -p -r1.545 -r1.546 >>--- gtkconv.c 24 Apr 2005 21:26:33 -0000 1.545 >>+++ gtkconv.c 26 Apr 2005 02:02:43 -0000 1.546 >>@@ -5358,7 +5358,7 @@ gaim_gtkconv_updated(GaimConversation *c >> } >> else if (gaim_conversation_get_unseen(conv) == GAIM_UNSEEN_NICK) >> { >>- strcpy(color, "#314E6C"); >>+ strcpy(color, "#0D4E91"); >> } >> else if (gaim_conversation_get_unseen(conv) == GAIM_UNSEEN_TEXT) >> { >> >> >> >>------------------------------------------------------- >>SF email is sponsored by - The IT Product Guide >>Read honest & candid reviews on hundreds of IT Products from real users. >>Discover which products truly live up to the hype. Start reading now. >>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >>_______________________________________________ >>Gaim-commits mailing list >>Gai...@li... >>https://lists.sourceforge.net/lists/listinfo/gaim-commits > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > Gaim-devel mailing list > Gai...@li... > https://lists.sourceforge.net/lists/listinfo/gaim-devel > -- Martin (va PahaLOOM) Tel: +esä loomadel või +erakonnadel Jabber: pl...@ja... ICQ: 53393983 AIM: ploomik MSN: mar...@ma... http://www.pilt.ee/ploomik |