pidgin-devel

[Gaim-devel] Some patches (docklet tweaks, session management)

[Robert M. <rob...@de...>]

NB: For 'docklet', read 'tray icon'. Old habits die hard. =)

I found and fixed a little bug with the updating of the docklet's
connecting icon to the offline/online icon when you cancel the
connection process. The gist of it was that the connecting counter is
decremented after the plugin event for signoff is called, so that the
plugins are able to tell the connection was never fully established (for
whatever reason - this is just the way I did it =). Ironically for me,
my forethought backfired on the docklet, because it does need to know
when all the "connecting" gcs are gone, so it can set the right icon.
The fix is just to update the status in the g_idle handler, so it
happens after the connecting counter is decremented.

While I was there I got carried away and made the docklet menu all
purty, in the code and in the flesh. It now has icons like the buddy
list menus do, and the code is less iffy (in the sense of using if, and
in the sense of falling through incorrectly for some statuses) and more
switchy, which means it catches all the cases correctly. Yay!

Patch for this is at:
 http://people.debian.org/~robot101/docklet-purty-menu-and-fixed-icon.diff

And at the risk of harping on, I laboured one night and day to enable
Gaim to connect to a session manager (such as gnome-session) so that
when you log out (of GNOME for instance =) with Gaim running, it's
running the next time you log in. Once I've straightened a few other
things out, I anticipate adding the ability for it to save the state of
your accounts at log out, and restore them at log in, and also to allow
people to save their state at any time, so they can have presets for
'online' or 'invisible' or 'away', for example. In the meantime, I'd
appreciate people trying out the session management stuff if they use
KDE, GNOME, or even xsm.

The glue patch is at:
 http://people.debian.org/~robot101/sm-me-harder6.diff
And you need to put this file in the src/ directory:
 http://people.debian.org/~robot101/session.c
(and spot the minor warning fix in about.c =)

I'd appreciate it if anyone committed either or both of these.

Regards,
Rob

Re: [Gaim-devel] Some patches (docklet tweaks, session management)

[Graham W. <bo...@de...>]

On Mon, Dec 30, 2002 at 07:36:42AM +0000, Robert McQueen wrote:
> And at the risk of harping on, I laboured one night and day to enable
> Gaim to connect to a session manager (such as gnome-session) so that
> when you log out (of GNOME for instance =) with Gaim running, it's
> running the next time you log in.

neato.

> Once I've straightened a few other things out, I anticipate adding the
> ability for it to save the state of your accounts at log out, and
> restore them at log in, and also to allow people to save their state
> at any time, so they can have presets for 'online' or 'invisible' or
> 'away', for example.

might i add "support for saving window state". that is posistion,
whether or not it is shown, minimized, etc.

> In the meantime, I'd appreciate people trying out the session
> management stuff if they use KDE, GNOME, or even xsm.

im running gnome-session-manager, and it works fine.

--
gram

Re: [Gaim-devel] Some patches (docklet tweaks, session management)

[Robert M. <rob...@de...>]

On Tue, Dec 31, 2002 at 01:56:36AM -0600, Graham Wilson wrote:
> might i add "support for saving window state". that is posistion,
> whether or not it is shown, minimized, etc.

Ha. Well, if you use the tray icon [*] and enable the option, the buddy
list currently tries to save and restore its posisition, with
*exceedingly* variable results depending on how broken your WM is. I'm
not going to enter into a loosing battle trying to store things about
windows which might not be there (conversation windows, buddy list (what
if signon fails?), error dialogs, etc), and open up the way for
countless bug reports about how people's buggy WMs handle the ICCM
standard from one week to the next.

Besides, I *think* the session manager is supposed to restore the window
configuration of correctly role-hinted windows, and we're setting all
the role hints on our windows now. Failing that you can get your WM to
do it.

> im running gnome-session-manager, and it works fine.

Cool, thanks for the feedback. The patch got merged yesterday. Woohoo!
=)

> --
> gram

Regards,
Rob

[*]: Although this distinction is no longer strictly necessary. The
position saving and restoring code had to be implemented in Gaim and not
in the plugin, so if people want there's no reason the blist position
save/restore can't be made available to everyone. It works reasonably
well currently. Let me know if I should bother.

Re: [Gaim-devel] Some patches (docklet tweaks, session management)

[Graham W. <bo...@de...>]

On Tue, Dec 31, 2002 at 05:26:33PM +0000, Robert McQueen wrote:
> On Tue, Dec 31, 2002 at 01:56:36AM -0600, Graham Wilson wrote:
> > might i add "support for saving window state". that is posistion,
> > whether or not it is shown, minimized, etc.
>=20
> Ha. Well, if you use the tray icon [*] and enable the option, the buddy
> list currently tries to save and restore its posisition, with
> *exceedingly* variable results depending on how broken your WM is.

since i think it is the window managers responsibility to do that, im
not to worried about position saving.

> I'm not going to enter into a loosing battle trying to store things
> about windows which might not be there (conversation windows, buddy
> list (what if signon fails?), error dialogs, etc), and open up the way
> for countless bug reports about how people's buggy WMs handle the ICCM
> standard from one week to the next.

that makes sense.

what i really thought it would be nice to save is if the buddy list is
actually displayed on screen. with the system tray icon, the window can
either be shown or hidden, and i think it would be useful to save that.

> Besides, I *think* the session manager is supposed to restore the
> window configuration of correctly role-hinted windows, and we're
> setting all the role hints on our windows now.

i think it is the role of the window manager, at least that is how
metacity and twm do it. when the session manager calls the
SmcSaveYourself callback, both of theses window managers save the
posistion of each of the windows that it is managing.

--=20
gram