Menu
▾
▴
pidgin-devel
|
From: David O. <Da...@di...> - 2002-10-17 15:37:54
Attachments:
patch.gaim.dindinx6.bz2
|
Hi,
Here is a new version of the GtkTextView/GtkTextBuffer patch.
Almost every feature of the old input entry is now included into the new
widget. It is very usable.
And since the utf8 problem as been fixed the right way, I've removed
these wierdness from this patch.
The patch is of course against CVS HEAD. Please report problems and/or
please include it directly in the CVS ;-)
Best regards,
DindinX
--
Da...@di...
When a girl can read the handwriting on the wall, she may be in the wrong
rest room.
|
|
From: Ethan B. <ebl...@cs...> - 2002-10-17 17:15:09
|
David Odin spake unto us the following wisdom:
> And since the utf8 problem as been fixed the right way, I've removed
> these wierdness from this patch.
So I guess my last patch to Oscar UTF-8 support fixed it for you?
Ethan
--=20
And if I claim to be a wise man / it surely means that I don't know.
-- Kansas, "Carry on Wayward Son"
|
|
From: David O. <Da...@di...> - 2002-10-17 17:30:20
|
On Thu, Oct 17, 2002 at 12:14:21PM -0500, Ethan Blanton wrote:
> David Odin spake unto us the following wisdom:
> > And since the utf8 problem as been fixed the right way, I've removed
> > these wierdness from this patch.
>
> So I guess my last patch to Oscar UTF-8 support fixed it for you?
>
Yes, exactly. With your patch I can received correct input from both
correct (gaim cvs, aim/windows) and broken (gaim 0.58) clients. So I
don't need to play with this anymore.
Thanks a lot.
DindinX
P.S: did you get any time to have a look at my patch? I would be more
than happy if it could be commited into cvs.
--
Da...@di...
|
|
From: Ethan B. <ebl...@cs...> - 2002-10-17 17:43:14
|
David Odin spake unto us the following wisdom:
> P.S: did you get any time to have a look at my patch? I would be more
> than happy if it could be commited into cvs.
I'm testing it out right at this moment. I'll be excited if it can be
committed, too, but first I have to make sure that it works with, for
instance, Asian scripts.
Ethan
--=20
And if I claim to be a wise man / it surely means that I don't know.
-- Kansas, "Carry on Wayward Son"
|
|
From: Luke S. <lsc...@gm...> - 2002-10-17 17:57:01
|
as i sign in irc and am auto-joined into several channels, the following happens: (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 3377 (gtk_text_buffer_get_selection_bounds): assertion `GTK_IS_TEXT_BUFFER (buffer)' failed (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 2447 (gtk_text_buffer_get_start_iter): assertion `GTK_IS_TEXT_BUFFER (buffer)' failed (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 1871 (gtk_text_buffer_get_insert): assertion `GTK_IS_TEXT_BUFFER (buffer)' failed (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 1727 (gtk_text_buffer_get_iter_at_mark): assertion `GTK_IS_TEXT_MARK (mark)' failed (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 1399 (gtk_text_buffer_get_text): assertion `GTK_IS_TEXT_BUFFER (buffer)' failed Removed core Oh no! Segmentation fault! gaim (pid:1882): [E]xit, [H]alt, show [S]tack trace or [P]roceed: s #0 0x4035d8fc in g_on_error_stack_trace () from /usr/lib/libglib-2.0.so.0 #1 0x4035d81e in g_on_error_query () from /usr/lib/libglib-2.0.so.0 #2 0x0805c8bd in sighandler (sig=11) at aim.c:394 #3 0x403e8a44 in pthread_sighandler () from /lib/libpthread.so.0 #4 0x40534518 in sigaction () from /lib/libc.so.6 #5 0x0806cb6d in count_tag (buffer=0x0, s1=0x80b990f "<B>", #6 0x0806d65f in check_everything (buffer=0x8433330) at conversation.c:1738 #7 0x0806cb05 in entry_key_pressed (buffer=0x8433330) at conversation.c:1374 #8 0x400eda42 in _gtk_marshal_BOOLEAN__BOXED () #9 0x4031de2b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 #10 0x40331993 in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0 #11 0x40330277 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 #12 0x40122cbf in gtk_signal_emit () from /usr/lib/libgtk-x11-2.0.so.0 #13 0x401a2e8d in gtk_widget_send_expose () from /usr/lib/libgtk-x11-2.0.so.0 #14 0x401a2af0 in gtk_widget_event () from /usr/lib/libgtk-x11-2.0.so.0 #15 0x401acc30 in _gtk_window_query_nonaccels () #16 0x400eda42 in _gtk_marshal_BOOLEAN__BOXED () #17 0x4031e205 in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0 #18 0x4031de2b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 #19 0x40331d8a in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0 #20 0x40330277 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 #21 0x40122cbf in gtk_signal_emit () from /usr/lib/libgtk-x11-2.0.so.0 #22 0x401a2e8d in gtk_widget_send_expose () from /usr/lib/libgtk-x11-2.0.so.0 #23 0x401a2af0 in gtk_widget_event () from /usr/lib/libgtk-x11-2.0.so.0 #24 0x400ed8bd in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0 #25 0x400ec8fe in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0 #26 0x4026b05c in _gdk_events_queue () from /usr/lib/libgdk-x11-2.0.so.0 #27 0x4036fa19 in g_get_current_time () from /usr/lib/libglib-2.0.so.0 #28 0x40370837 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #29 0x40370c13 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #30 0x403712ef in g_main_loop_run () from /usr/lib/libglib-2.0.so.0 #31 0x400ec00f in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #32 0x0805d32c in main (argc=2, argv=0xbffffb54) at aim.c:840 its all the way signed in and is processing the joins to the new chats and conversations at the time this happens. as it doesn't happen w/out the patch, i'm assuming your patch is causing it. luke On Thu, Oct 17, 2002 at 12:42:12PM -0500, Ethan Blanton wrote: > David Odin spake unto us the following wisdom: > > P.S: did you get any time to have a look at my patch? I would be more > > than happy if it could be commited into cvs. > > I'm testing it out right at this moment. I'll be excited if it can be > committed, too, but first I have to make sure that it works with, for > instance, Asian scripts. > > Ethan > > -- > And if I claim to be a wise man / it surely means that I don't know. > -- Kansas, "Carry on Wayward Son" -- -This email is made of 100% recycled electrons. |
|
From: David O. <Da...@di...> - 2002-10-17 20:14:42
|
On Thu, Oct 17, 2002 at 01:56:55PM -0400, Luke Schierer wrote:
> as i sign in irc and am auto-joined into several channels, the following
> happens:
>
>
> (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 3377
> (gtk_text_buffer_get_selection_bounds): assertion `GTK_IS_TEXT_BUFFER
> (buffer)' failed
>
> (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 2447
> (gtk_text_buffer_get_start_iter): assertion `GTK_IS_TEXT_BUFFER
> (buffer)' failed
>
> (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 1871
> (gtk_text_buffer_get_insert): assertion `GTK_IS_TEXT_BUFFER (buffer)'
> failed
>
> (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 1727
> (gtk_text_buffer_get_iter_at_mark): assertion `GTK_IS_TEXT_MARK (mark)'
> failed
>
> (gaim:1882): Gtk-CRITICAL **: file gtktextbuffer.c: line 1399
> (gtk_text_buffer_get_text): assertion `GTK_IS_TEXT_BUFFER (buffer)'
> failed
> Removed core
> Oh no! Segmentation fault!
> gaim (pid:1882): [E]xit, [H]alt, show [S]tack trace or [P]roceed: s
> #0 0x4035d8fc in g_on_error_stack_trace () from
> /usr/lib/libglib-2.0.so.0
> #1 0x4035d81e in g_on_error_query () from /usr/lib/libglib-2.0.so.0
> #2 0x0805c8bd in sighandler (sig=11) at aim.c:394
> #3 0x403e8a44 in pthread_sighandler () from /lib/libpthread.so.0
> #4 0x40534518 in sigaction () from /lib/libc.so.6
> #5 0x0806cb6d in count_tag (buffer=0x0, s1=0x80b990f "<B>",
> #6 0x0806d65f in check_everything (buffer=0x8433330) at
> conversation.c:1738
> #7 0x0806cb05 in entry_key_pressed (buffer=0x8433330) at
> conversation.c:1374
> #8 0x400eda42 in _gtk_marshal_BOOLEAN__BOXED ()
> #9 0x4031de2b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
> #10 0x40331993 in g_signal_emit_by_name () from
> /usr/lib/libgobject-2.0.so.0
> #11 0x40330277 in g_signal_emit_valist () from
> /usr/lib/libgobject-2.0.so.0
> #12 0x40122cbf in gtk_signal_emit () from /usr/lib/libgtk-x11-2.0.so.0
> #13 0x401a2e8d in gtk_widget_send_expose () from
> /usr/lib/libgtk-x11-2.0.so.0
> #14 0x401a2af0 in gtk_widget_event () from /usr/lib/libgtk-x11-2.0.so.0
> #15 0x401acc30 in _gtk_window_query_nonaccels ()
> #16 0x400eda42 in _gtk_marshal_BOOLEAN__BOXED ()
> #17 0x4031e205 in g_cclosure_new_swap () from
> /usr/lib/libgobject-2.0.so.0
> #18 0x4031de2b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
> #19 0x40331d8a in g_signal_emit_by_name () from
> /usr/lib/libgobject-2.0.so.0
> #20 0x40330277 in g_signal_emit_valist () from
> /usr/lib/libgobject-2.0.so.0
> #21 0x40122cbf in gtk_signal_emit () from /usr/lib/libgtk-x11-2.0.so.0
> #22 0x401a2e8d in gtk_widget_send_expose () from
> /usr/lib/libgtk-x11-2.0.so.0
> #23 0x401a2af0 in gtk_widget_event () from /usr/lib/libgtk-x11-2.0.so.0
> #24 0x400ed8bd in gtk_propagate_event () from
> /usr/lib/libgtk-x11-2.0.so.0
> #25 0x400ec8fe in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
> #26 0x4026b05c in _gdk_events_queue () from /usr/lib/libgdk-x11-2.0.so.0
> #27 0x4036fa19 in g_get_current_time () from /usr/lib/libglib-2.0.so.0
> #28 0x40370837 in g_main_context_dispatch () from
> /usr/lib/libglib-2.0.so.0
> #29 0x40370c13 in g_main_context_dispatch () from
> /usr/lib/libglib-2.0.so.0
> #30 0x403712ef in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
> #31 0x400ec00f in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
> #32 0x0805d32c in main (argc=2, argv=0xbffffb54) at aim.c:840
>
> its all the way signed in and is processing the joins to the new chats
> and conversations at the time this happens.
>
> as it doesn't happen w/out the patch, i'm assuming your patch is causing
> it.
> luke
>
Yep. This is probably due to my patch. I've changed many things in
conversation.c. such as the entry_key_pressed function, so that it now
use a GtkTextBuffer instead of a GtkText. For now, I only adapted the
conversation (one-to-one) window. I have yet to adapt some other window,
such as the buddy chat one which also use some function of
conversation.c.
I'll keep you informed about by progress.
By the way, I never use any buddy_chat. Would you agree to test a new
patch, to make sure I go in the right direction?
Thanks for the report.
DindinX
--
Da...@di...
Q: Why does Washington have the most lawyers per capita and
New Jersey the most toxic waste dumps?
A: God gave New Jersey first choice.
|
|
From: Ethan B. <ebl...@cs...> - 2002-10-17 17:55:00
|
David Odin spake unto us the following wisdom:
> Here is a new version of the GtkTextView/GtkTextBuffer patch.
> Almost every feature of the old input entry is now included into the new
> widget. It is very usable.
It seems very usable to me, also, as long as I don't try to use any X
input methods. The X input methods do not insert any text, and
sufficient beating on them seems to eventually cause gaim to lock up.
If this works well for ISO-8859-1 it's a huge step in the right
direction, but it's obviously missing something. I'll see if I can
figure out what, as other gaim text entries work properly.
Ethan
--=20
And if I claim to be a wise man / it surely means that I don't know.
-- Kansas, "Carry on Wayward Son"
|
|
From: David O. <Da...@di...> - 2002-10-17 18:30:26
|
On Thu, Oct 17, 2002 at 12:54:21PM -0500, Ethan Blanton wrote:
> David Odin spake unto us the following wisdom:
> > Here is a new version of the GtkTextView/GtkTextBuffer patch.
> > Almost every feature of the old input entry is now included into the new
> > widget. It is very usable.
>
> It seems very usable to me, also, as long as I don't try to use any X
> input methods. The X input methods do not insert any text, and
> sufficient beating on them seems to eventually cause gaim to lock up.
>
> If this works well for ISO-8859-1 it's a huge step in the right
> direction, but it's obviously missing something. I'll see if I can
> figure out what, as other gaim text entries work properly.
>
To change the input method, try to right-click in the input entry.
I've succesfully sent and received cyrillic, corean, and other
characters this way.
How do you change input method?
Regards,
DindinX
--
Da...@di...
|
|
From: Ethan B. <ebl...@cs...> - 2002-10-17 18:50:44
|
David Odin spake unto us the following wisdom:
> > If this works well for ISO-8859-1 it's a huge step in the right
> > direction, but it's obviously missing something. I'll see if I can
> > figure out what, as other gaim text entries work properly.
> >=20
>=20
> To change the input method, try to right-click in the input entry.
> I've succesfully sent and received cyrillic, corean, and other
> characters this way.
The input method is XIM, the problem is that it is not accepting the
input characters from kinput2. kinput2 is properly initialized and I
can type into it just fine, but when I push <Enter> to send text to
the GtkTextView, it is not properly sent. (nothing happens)
I'm looking into it right now ... but first I'm having to clean up a
lot of gratuitous reformatting in this patch so I can figure out what
is going on. :-P Please use tabs for indentation and follow the gaim
style of putting { on the same line as if (), in the future. :-)
Ethan
--=20
And if I claim to be a wise man / it surely means that I don't know.
-- Kansas, "Carry on Wayward Son"
|
|
From: David O. <Da...@di...> - 2002-10-17 20:14:17
|
On Thu, Oct 17, 2002 at 01:50:05PM -0500, Ethan Blanton wrote:
> David Odin spake unto us the following wisdom:
> > > If this works well for ISO-8859-1 it's a huge step in the right
> > > direction, but it's obviously missing something. I'll see if I can
> > > figure out what, as other gaim text entries work properly.
> > >
> >
> > To change the input method, try to right-click in the input entry.
> > I've succesfully sent and received cyrillic, corean, and other
> > characters this way.
>
> The input method is XIM, the problem is that it is not accepting the
> input characters from kinput2. kinput2 is properly initialized and I
> can type into it just fine, but when I push <Enter> to send text to
> the GtkTextView, it is not properly sent. (nothing happens)
>
I've never used kinput2. I'm trying it right now.
>
> I'm looking into it right now ... but first I'm having to clean up a
> lot of gratuitous reformatting in this patch so I can figure out what
> is going on. :-P Please use tabs for indentation and follow the gaim
> style of putting { on the same line as if (), in the future. :-)
>
Sure. Sorry for this. How much characters do you use for tabs?
Regards,
DindinX
--
Da...@di...
"This is my gift, it is my curse."
|
|
From: Ethan B. <ebl...@cs...> - 2002-10-17 20:23:28
|
David Odin spake unto us the following wisdom:
> Sure. Sorry for this. How much characters do you use for tabs?
8 spaces per tab, and the code is actually *tabs* and not 8 spaces.
Ethan
--=20
And if I claim to be a wise man / it surely means that I don't know.
-- Kansas, "Carry on Wayward Son"
|
|
From: David O. <Da...@di...> - 2002-10-18 13:35:07
Attachments:
patch.gaim.dindinx8.bz2
|
On Thu, Oct 17, 2002 at 03:23:02PM -0500, Ethan Blanton wrote:
> David Odin spake unto us the following wisdom:
> > Sure. Sorry for this. How much characters do you use for tabs?
>
> 8 spaces per tab, and the code is actually *tabs* and not 8 spaces.
>
OK. Then you should try the attached patch which fix the indentation.
Please try and report problems.
Regards,
DindinX
--
Da...@di...
We may not return the affection of those who like us, but we always respect
their good judgement.
|
|
From: <lsc...@re...> - 2002-10-18 13:56:36
|
tab complete nicks in chat does not work with this version of the patch. luke On Fri, Oct 18, 2002 at 03:35:01PM +0200, David Odin wrote: > On Thu, Oct 17, 2002 at 03:23:02PM -0500, Ethan Blanton wrote: > > David Odin spake unto us the following wisdom: > > > Sure. Sorry for this. How much characters do you use for tabs? > > > > 8 spaces per tab, and the code is actually *tabs* and not 8 spaces. > > > OK. Then you should try the attached patch which fix the indentation. > > Please try and report problems. > > Regards, > > DindinX > > -- > Da...@di... > We may not return the affection of those who like us, but we always respect > their good judgement. -- -This email is made of 100% recycled electrons. |
|
From: David O. <Da...@di...> - 2002-10-18 14:18:37
|
On Fri, Oct 18, 2002 at 09:56:33AM -0400, lsc...@re... wrote: > tab complete nicks in chat does not work with this version of the patch. > luke > Yes. I've disabled it for now, until I fully understand how it work so I can adapt it for GtkTextView/GtkTextBuffer. -- Da...@di... It's not that I'm afraid to die. I just don't want to be there when it happens. -- Woody Allen |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X