pidgin-devel

[Gaim-devel] [PATCH] Minor change

[Gabriel S. <ni...@go...>]

# Hi!
# Can we please have the following at the top of gtkutils.c ? I
# really need this for Gaim to build
#
# TIA,
#
#
#
# Gabriel
Index: gtk/gtkutils.c
===================================================================
--- gtk/gtkutils.c      (revision 18228)
+++ gtk/gtkutils.c      (working copy)
@@ -22,6 +22,10 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
USA
  */
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif /* def HAVE_CONFIG_H */
 #include "internal.h"
 #include "gtkgaim.h"
 

Re: [Gaim-devel] [PATCH] Minor change

[Evan S. <ev...@dr...>]

It's already at the top of internal.h which is the first #include  
there...

-Evan

On Apr 2, 2007, at 6:53 PM, Gabriel Schulhof wrote:

> # Hi!
> # Can we please have the following at the top of gtkutils.c ? I
> # really need this for Gaim to build
> #
> # TIA,
> #
> #
> #
> # Gabriel
> Index: gtk/gtkutils.c
> ===================================================================
> --- gtk/gtkutils.c      (revision 18228)
> +++ gtk/gtkutils.c      (working copy)
> @@ -22,6 +22,10 @@
>   * along with this program; if not, write to the Free Software
>   * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA   
> 02111-1307
> USA
>   */
> +
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif /* def HAVE_CONFIG_H */
>  #include "internal.h"
>  #include "gtkgaim.h"
>
>
>
>
> ---------------------------------------------------------------------- 
> ---
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to  
> share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php? 
> page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Gaim-devel mailing list
> Gai...@li...
> https://lists.sourceforge.net/lists/listinfo/gaim-devel
>

Re: [Gaim-devel] [PATCH] Minor change

[Gabriel S. <ni...@go...>]

On Mon, 2007-04-02 at 19:08 -0400, Evan Schoenberg wrote:
> It's already at the top of internal.h which is the first #include  
> there...
Truth. And, sure enough, using a #ifdef based on a config.h directive
does work after including "internal.h" :o) In that case, I'm hoping you
can help me with "the real" problem. For some reason, in the environment
I'm using, the files gtkutil.c and gtkimhtml.c do not compile because of
implicit declarations of strncasecmp. For example:

gtkimhtml.c:2217: error: implicit declaration of function `strncasecmp'
gtkimhtml.c:2217: warning: nested extern declaration of `strncasecmp'

Now, I'm not sure how to properly include strings.h. Is it

#ifndef _WIN32
#ifdef HAVE_STRINGS_H
#include <strings.h>
#endif /* def HAVE_STRINGS_H */
#endif /* ndef _WIN32 */

If so, and if this does not interfere with other builds, it is
really /this/ that I would need at the top of both gtkutils.c and
gtkimhtml.c .

Currently I am making inclusion of <strings.h> conditional on a
directive introduced by a downstream patch (which resides in config.h,
which brought my original question :o) ). However, if there are build
environments where <strings.h> does not "reach" these two files though
it should, perhaps this is a candidate for an upstream fix.

Please let me know,



Gabriel