pidgin-devel

[Gaim-devel] gaim_gtk_prefs_dropdown_from_list GtkOptionMenu -> GtkComboBox

[Gabriel S. <ni...@go...>]

Hi!

Why does the preferences dialog contain so many GtkOptionMenus instead ?
I have a patch that causes gaim_gtk_prefs_dropdown_from_list to create a
GtkComboBox instead of a GtkOptionMenu.

Is this mailing list a good place to post it ?

TIA,



Gabriel

Re: [Gaim-devel] gaim_gtk_prefs_dropdown_from_list GtkOptionMenu -> GtkComboBox

[Sean E. <sea...@gm...>]

On 3/27/07, Gabriel Schulhof <ni...@go...> wrote:
> Hi!

Hi!

> Why does the preferences dialog contain so many GtkOptionMenus instead ?
> I have a patch that causes gaim_gtk_prefs_dropdown_from_list to create a
> GtkComboBox instead of a GtkOptionMenu.

Because GtkComboBox was introduced in GTK+ 2.4 (I think... somewhere
thereabout... maybe 2.6), and Gaim is obligated to run on GTK+ 2.0.

For Gaim 2.0.0, we decided we wanted to use GtkComboBox for our status
dropdown, but later abandoned that idea. Because of that, we have our
own version of GtkComboBox in the Gaim source tree, but I'd prefer
using that less than more.

-s.

Re: [Gaim-devel] gaim_gtk_prefs_dropdown_from_list GtkOptionMenu -> GtkComboBox

[Gabriel S. <ni...@go...>]

On Tue, 2007-03-27 at 14:22 -0700, Sean Egan wrote:
> Because GtkComboBox was introduced in GTK+ 2.4 (I think... somewhere
> thereabout... maybe 2.6), and Gaim is obligated to run on GTK+ 2.0.

Aaaah, OK.

Well, I /did/ structured my patch using #ifdef statements, so I could
replace my current #ifdef condition with GTK_CHECK_VERSION. We would
then have GtkComboBoxes if the version is high enough, and fall back to
GtkOptionMenu otherwise.

Would that be acceptable ?



Gabriel