Menu
▾
▴
pidgin-devel
|
From: Shaya P. <sp...@cs...> - 2003-04-06 08:17:00
|
here's a simple patch that lets me minimize the away window, and not have it act like an always on top dialog. spotter@zaphod:~/cvs/gaim/src$ cvs diff away.c Index: away.c =================================================================== RCS file: /cvsroot/gaim/gaim/src/away.c,v retrieving revision 1.93 diff -r1.93 away.c 214c214 < GAIM_DIALOG(imaway); --- > imaway = gtk_window_new(GTK_WINDOW_TOPLEVEL); |
|
From: Decklin F. <de...@re...> - 2003-04-06 13:41:39
|
Shaya Potter writes: > here's a simple patch that lets me minimize the away window, and not > have it act like an always on top dialog. > > imaway = gtk_window_new(GTK_WINDOW_TOPLEVEL); This is wrong. _NET_WM_WINDOW_TYPE is a semantic hint; If your window manager is making all such windows "always on top" or now allowing you to iconify them, and you don't like that, you should fix your window manager. Also, please use diff -u. (Aside: why doesn't gtk set WM_TRANSIENT_FOR as well? "Dialog", to me, implies transience. But perhaps there was a good reason for this change... didn't we use GTK_WINDOW_DIALOG at some point?) -- things change. de...@re... |
|
From: Robert L. <rm...@te...> - 2003-04-06 18:36:45
|
On Sun, 2003-04-06 at 04:14, Shaya Potter wrote: > here's a simple patch that lets me minimize the away window, and not > have it act like an always on top dialog. Can't we just get rid of this silly window altogether? There was some sentiment to this effect on GNOME Footnotes yesterday. If I recall, a chap named Chris Rivera posted a patch to make the away dialog an option. Robert Love |
|
From: Shaya P. <sp...@cs...> - 2003-04-06 18:42:29
|
On Sun, 2003-04-06 at 14:36, Robert Love wrote: > On Sun, 2003-04-06 at 04:14, Shaya Potter wrote: > > here's a simple patch that lets me minimize the away window, and not > > have it act like an always on top dialog. > > Can't we just get rid of this silly window altogether? > > There was some sentiment to this effect on GNOME Footnotes yesterday. > If I recall, a chap named Chris Rivera posted a patch to make the away > dialog an option. well, both are valid approaches I think. 1) the windows itself should be an option 2) the window should be an option if it's a dialog or not. though giving all these options doesn't seem very HIGy :) |
|
From: Shaya P. <sp...@cs...> - 2003-04-06 21:53:25
|
Here's a unified diff as requested.
spotter@zaphod:~/cvs/gaim/src$ cvs diff -u away.c
Index: away.c
===================================================================
RCS file: /cvsroot/gaim/gaim/src/away.c,v
retrieving revision 1.93
diff -u -r1.93 away.c
--- away.c 5 Apr 2003 05:01:28 -0000 1.93
+++ away.c 6 Apr 2003 21:47:28 -0000
@@ -211,7 +211,7 @@
return;
if (!imaway) {
- GAIM_DIALOG(imaway);
+ imaway = gtk_window_new(GTK_WINDOW_TOPLEVEL);
gtk_window_set_role(GTK_WINDOW(imaway), "imaway");
if (strlen(a->name))
gtk_window_set_title(GTK_WINDOW(imaway), a->name);
as GAIM_DIALOG is just
#define GAIM_DIALOG(x) x = gtk_window_new(GTK_WINDOW_TOPLEVEL); \
gtk_window_set_type_hint(GTK_WINDOW(x),
GDK_WINDOW_TYPE_HINT_DIALOG)
it's not much of a change, only removing the dialog hint. The reason
for this being that metacity views dialog's as being part of the parent,
and unminimizable (is that a word?). I know I like to go "auto away" and
minimize the message out of the way, but with the current source I can't
do that.
I still want the window around (hence why the patch to make the window a
pref doesn't help me), and this hint just doesn't seem to accomplish
anything usefull (besides perhaps under some window manager forcing it
to be minimized with the parent) as most window managers (based on what
people say in #gaim) seem to ignore the hint. I don't mind the dialog
hint on things like prefs, but it seems overkill for the away window.
shaya (oh and not subscribed, so cc me)
On Sun, 2003-04-06 at 14:40, Shaya Potter wrote:
> On Sun, 2003-04-06 at 14:36, Robert Love wrote:
> > On Sun, 2003-04-06 at 04:14, Shaya Potter wrote:
> > > here's a simple patch that lets me minimize the away window, and not
> > > have it act like an always on top dialog.
> >
> > Can't we just get rid of this silly window altogether?
> >
> > There was some sentiment to this effect on GNOME Footnotes yesterday.
> > If I recall, a chap named Chris Rivera posted a patch to make the away
> > dialog an option.
>
> well, both are valid approaches I think.
>
> 1) the windows itself should be an option
> 2) the window should be an option if it's a dialog or not.
>
> though giving all these options doesn't seem very HIGy :)
|
|
From: Decklin F. <de...@re...> - 2003-04-06 23:04:50
|
Shaya Potter writes: > The reason for this being that metacity views dialog's as being part > of the parent, and unminimizable (is that a word?). Actually... the more I think about it, the less sense the away message window makes as a "dialog". *Maybe* transient, as it's subordinate to the blist and not permanent, but it doesn't fulfill the "ask user for more info before going ahead with something" definition of a dialog. I still think this is a horribly misguided feature in metacity, however. But then I'm sure Havoc thinks all sorts of things I've done in aewm are stupid too (like not implementing _NET_ANYTHING). ;-) As for the HIG issues... This is really not worth adding a preference for. I would be perfectly happy if we killed the window entirely, as I have myself on my buddy list and can check my status that way. Whatever. But we should pick something right and go with it. I've been thinking a menu reorganization is probably in order. Allowing for a check mark somewhere to say "yes, away is set" would probably be a good idea. I'll have to think about that some more. > and this hint just doesn't seem to accomplish anything usefull > (besides perhaps under some window manager forcing it to be minimized > with the parent) Well, as i said, it's a semantic and not a behavioral hint (think <em> versus <i> in HTML). We shouldn't concern ourself with the decisions that users make (through their WM) about how to deal with that markup, only with applying it correctly. > shaya (oh and not subscribed, so cc me) Sorry, didn't mean to leave you out of the loop last time. -- things change. de...@re... |
|
From: Adrian D. <adr...@gm...> - 2003-04-07 14:58:10
|
=2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jesus, first I mailed it to to Decklin, instead of the list and then I forg= ot=20 to change the Subject. Anyways, I wonder why nobody noticed but there are=20 only win0.60-alpha files on the servers. Not a single .bz .rpm or anything= =20 for 0.60 on linux. The nightlies are dated older than the official 0.60=20 release. I use automake 1.7.3, so much for cvs ... Adrian =2D----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE+ka1JFyp8AaAsy0wRArgEAKCV9ujGHADy4HzrTaIeCL2FenM4IQCgi5L+ WkDVm224OvooUGsee6JUytI=3D =3Da+D8 =2D----END PGP SIGNATURE----- |
|
From: Jean C. <cj...@hu...> - 2003-04-07 15:03:51
|
Hi,
I don't know wich servers you are looking at, but on the official one
you can find the new fresh 0.60
0.60 2003-04-05 05:00
gaim-0.60-3.i386.rpm 1618060 382 i386.rpm
gaim-0.60-3.src.rpm 3019071 96 AnySource .rpm
gaim-0.60-3mdk.i586.rpm 1517812 0 Other.rpm
gaim-0.60-3mdk.src.rpm 3019105 0 AnySource .rpm
gaim-0.60.exe 1860903 1806 i386.exe (32-bit Windows)
gaim-0.60.tar.bz 22219758 3165 AnySource .bz2
gaim-0.60.tar.gz 2989283 1129 AnySource .gz
On Mon, 2003-04-07 at 18:54, Adrian Dannberg wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Jesus, first I mailed it to to Decklin, instead of the list and then I forgot
> to change the Subject. Anyways, I wonder why nobody noticed but there are
> only win0.60-alpha files on the servers. Not a single .bz .rpm or anything
> for 0.60 on linux. The nightlies are dated older than the official 0.60
> release. I use automake 1.7.3, so much for cvs ...
>
> Adrian
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.7 (GNU/Linux)
>
> iD8DBQE+ka1JFyp8AaAsy0wRArgEAKCV9ujGHADy4HzrTaIeCL2FenM4IQCgi5L+
> WkDVm224OvooUGsee6JUytI=
> =a+D8
> -----END PGP SIGNATURE-----
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: ValueWeb:
> Dedicated Hosting for just $79/mo with 500 GB of bandwidth!
> No other company gives more support or power for your dedicated server
> http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/
> _______________________________________________
> Gaim-devel mailing list
> Gai...@li...
> https://lists.sourceforge.net/lists/listinfo/gaim-devel
--
_ _ __ ____ __________________ ___ __ _ _
Jean Collonville
web : http://www.hungmaow.org
icq : 10205857
_ _ __ ____ ______________________________ ___ __ _ _
|
|
From: Luke S. <lsc...@ra...> - 2003-04-07 15:05:01
|
On Mon, Apr 07, 2003 at 05:54:33PM +0100, Adrian Dannberg wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jesus, first I mailed it to to Decklin, instead of the list and then I forgot > to change the Subject. Anyways, I wonder why nobody noticed but there are > only win0.60-alpha files on the servers. Not a single .bz .rpm or anything > for 0.60 on linux. The nightlies are dated older than the official 0.60 > release. I use automake 1.7.3, so much for cvs ... many of the sf mirrors seem very slow to update. yesterday peoplew were having trouble finding the wingaim binary (the only .exe), now you report trouble finding .tar.gz and .tar.bz, i can only say to try a different mirror, they are all there. luke |
|
From: Rob F. <ro...@fa...> - 2003-04-07 15:39:25
|
I'll speak to some people at SF.net and see what's up. - R > On Mon, Apr 07, 2003 at 05:54:33PM +0100, Adrian Dannberg wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Jesus, first I mailed it to to Decklin, instead of the list and then I >> forgot to change the Subject. Anyways, I wonder why nobody noticed >> but there are only win0.60-alpha files on the servers. Not a single >> .bz .rpm or anything for 0.60 on linux. The nightlies are dated older >> than the official 0.60 release. I use automake 1.7.3, so much for cvs >> ... > > many of the sf mirrors seem very slow to update. yesterday peoplew were > having trouble finding the wingaim binary (the only .exe), now you > report trouble finding .tar.gz and .tar.bz, i can only say to try a > different mirror, they are all there. > luke > > > ------------------------------------------------------- > This SF.net email is sponsored by: ValueWeb: > Dedicated Hosting for just $79/mo with 500 GB of bandwidth! > No other company gives more support or power for your dedicated server > http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/ > _______________________________________________ > Gaim-devel mailing list > Gai...@li... > https://lists.sourceforge.net/lists/listinfo/gaim-devel |
Thanks for helping keep SourceForge clean.
X