Thread: [Gaim-devel] Patch

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Hi! :) 

I wrote a little GAIM patch to allow simultaneous local and remote
alias. I need it :P

Feel free to apply. :)


-- 
Rubén Garrigós Domínguez <ru...@pa...>

On Sun, Feb 16, 2003 at 05:38:48PM +0100, Rubén Garrigós Domínguez wrote:
> Hi! :) 
> 
> I wrote a little GAIM patch to allow simultaneous local and remote
> alias. I need it :P
> 
> Feel free to apply. :)
> 
> -- 
> Rubén Garrigós Domínguez <ru...@pa...>

Please generate your patch with 'cvs diff -u' so that we can see the
context of the changes you have made, and still be able to apply the
patch even if our trees have changed some. That aside, why do you need
it, and more importantly, why do any other Gaim users need it? :P

Regards,
Rob

--- gaim-cvs/gaim/src/dialogs.c	2003-01-31 05:03:43.000000000 -0800
+++ src/dialogs.c	2003-02-14 17:23:27.000000000 -0800
@@ -2409,8 +2409,14 @@
 	GtkWidget *sw;
 	gint options =3D 0;
 	char *more_info;
+	char *window_title;
+	char *window_text =3D "Gaim - Buddy info for ";
 	va_list ap;
=20
+	window_title =3D (char *)calloc((strlen(window_text) + strlen(who) + 1), =
sizeof(char));
+	strcat(window_title, window_text);
+	strcat(window_title, who);
+=09
 	struct info_dlg *b =3D find_info_dlg(gc, who);
 	if (!b && (away =3D=3D 1))
 		return;
@@ -2421,11 +2427,12 @@
 		info_dlgs =3D g_slist_append(info_dlgs, b);
=20
 		GAIM_DIALOG(b->window);
-		gtk_window_set_title(GTK_WINDOW(b->window), "Gaim");
+		gtk_window_set_title(GTK_WINDOW(b->window), window_title);
 		gtk_container_border_width(GTK_CONTAINER(b->window), 5);
 		gtk_widget_realize(GTK_WIDGET(b->window));
 		g_signal_connect(GTK_OBJECT(b->window), "destroy", G_CALLBACK(info_dlg_f=
ree), b);
=20
+		free(window_title);
 		bbox =3D gtk_vbox_new(FALSE, 5);
 		gtk_container_add(GTK_CONTAINER(b->window), bbox);
=20

That becomes a little odd if you have more than one account signed on...


On Sun, 2003-02-16 at 19:56, Joel Smith wrote:
> On Sun, 2003-02-16 at 09:50, Robert McQueen wrote: 
>         That aside, why do you need it, and more importantly, why do any other Gaim users need it? :P
> It's okay to e-mail the list with small patches?  Here's one of mine. 
> It changes the window-manager title of the buddy info dialog from
> "Gaim" to "Gaim - Buddy info for [user's screen name]".  This is
> something that's bugged me for a while :-). 
> 
> Regards, 
> Joel
-- 
Rob Flynn <ro...@fa...>




Oh, I see that now.  This is what I get for only testing it with AIM
:'(. 

IRC seems to work a little differently.  'who' is NULL when
g_show_info_text(.....) is called when looking up an IRC buddy. 

Sorry!  I guess I have more to work on. 

Regards, 
Joel 

On Sun, 2003-02-16 at 16:59, Rob Flynn wrote:

    That becomes a little odd if you have more than one account signed on...
    
    
    On Sun, 2003-02-16 at 19:56, Joel Smith wrote:
    > On Sun, 2003-02-16 at 09:50, Robert McQueen wrote: 
    >         That aside, why do you need it, and more importantly, why do any other Gaim users need it? :P
    > It's okay to e-mail the list with small patches?  Here's one of mine. 
    > It changes the window-manager title of the buddy info dialog from
    > "Gaim" to "Gaim - Buddy info for [user's screen name]".  This is
    > something that's bugged me for a while :-). 
    > 
    > Regards, 
    > Joel
    -- 
    Rob Flynn <ro...@fa...>
    
    
    
    -------------------------------------------------------
    This sf.net email is sponsored by:ThinkGeek
    Welcome to geek heaven.
    http://thinkgeek.com/sf
    _______________________________________________
    Gaim-devel mailing list
    Gai...@li...

https://lists.sourceforge.net/lists/listinfo/gaim-devel

    

On Sun, 2003-02-16 at 20:42, Joel Smith wrote:
> Oh, I see that now.  This is what I get for only testing it with AIM
> :'(. 
> 
> IRC seems to work a little differently.  'who' is NULL when
> g_show_info_text(.....) is called when looking up an IRC buddy. 
> 
> Sorry!  I guess I have more to work on. 

Further, that function is not limited to just showing profiles or away
messages.  It's used for search results, and, like, other things too.

Also, the new preferred window title format would be "Sean Egan's User
Info" or something similar, rather than "Gaim - User info for SeanEgn". 
We want to put the important thing (the screenname) right at the
begininning of the title, so that you can see it when your taskbar
truncates window titles and stuff.

Finally:
+       char *window_title;
+       char *window_text = "Gaim - Buddy info for ";
        va_list ap;
 
+       window_title = (char *)calloc((strlen(window_text) + strlen(who)
+ 1), sizeof(char));
+       strcat(window_title, window_text);
+       strcat(window_title, who);

should be:
char *window_text = g_strdup_printf("Gaim - Buddy info for %s", who);

-s.




Thread: [Gaim-devel] Patch

A universal instant messaging (IM) program

pidgin-devel