From: <de...@us...> - 2006-08-21 06:07:00
|
Revision: 16946 Author: deryni9 Date: 2006-08-20 23:06:54 -0700 (Sun, 20 Aug 2006) ViewCVS: http://svn.sourceforge.net/gaim/?rev=16946&view=rev Log Message: ----------- Use the gtk conversation unseen_count instead of keeping my own count. Modified Paths: -------------- trunk/gtk/plugins/notify.c Modified: trunk/gtk/plugins/notify.c =================================================================== --- trunk/gtk/plugins/notify.c 2006-08-21 05:49:20 UTC (rev 16945) +++ trunk/gtk/plugins/notify.c 2006-08-21 06:06:54 UTC (rev 16946) @@ -107,7 +107,7 @@ static GaimPlugin *my_plugin = NULL; /* notification set/unset */ -static int notify(GaimConversation *conv, gboolean increment); +static int notify(GaimConversation *conv); static void notify_win(GaimGtkWindow *gaimwin); static void unnotify(GaimConversation *conv, gboolean reset); static int unnotify_cb(GtkWidget *widget, gpointer data, GaimConversation *conv); @@ -135,28 +135,26 @@ /****************************************/ /* Begin doing stuff below this line... */ /****************************************/ -static int +static guint count_messages(GaimGtkWindow *gaimwin) { - gint count = 0; - GList *convs = NULL, *l; + guint count = 0; + GList *gtkconvs = NULL; - for (convs = gaimwin->gtkconvs; convs != NULL; convs = convs->next) { - GaimGtkConversation *conv = convs->data; - for (l = conv->convs; l != NULL; l = l->next) { - count += GPOINTER_TO_INT(gaim_conversation_get_data(l->data, "notify-message-count")); - } + for (gtkconvs = gaimwin->gtkconvs; gtkconvs != NULL; + gtkconvs = gtkconvs->next) { + GaimGtkConversation *gtkconv = gtkconvs->data; + count += gtkconv->unseen_count; } return count; } static int -notify(GaimConversation *conv, gboolean increment) +notify(GaimConversation *conv) { - GaimGtkWindow *gaimwin = NULL; - gint count; gboolean has_focus; + GaimGtkWindow *gaimwin = NULL; if (conv == NULL) return 0; @@ -178,12 +176,6 @@ if (gaim_prefs_get_bool("/plugins/gtk/X11/notify/type_focused") || !has_focus) { - if (increment) { - count = GPOINTER_TO_INT(gaim_conversation_get_data(conv, "notify-message-count")); - count++; - gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(count)); - } - notify_win(gaimwin); } @@ -225,7 +217,6 @@ * just to have it readded in re-notify is an unnecessary couple extra RTs * to the server */ handle_urgent(gaimwin, FALSE); - gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); } return; @@ -234,7 +225,11 @@ static int unnotify_cb(GtkWidget *widget, gpointer data, GaimConversation *conv) { - if (GPOINTER_TO_INT(gaim_conversation_get_data(conv, "notify-message-count")) != 0) + GaimGtkConversation *gtkconv = NULL; + + gtkconv = GAIM_GTK_CONVERSATION(conv); + + if (gtkconv->unseen_count > 0) unnotify(conv, TRUE); return 0; @@ -250,7 +245,7 @@ return FALSE; if ((flags & GAIM_MESSAGE_RECV) && !(flags & GAIM_MESSAGE_DELAYED)) - notify(conv, TRUE); + notify(conv); return FALSE; } @@ -353,8 +348,6 @@ g_signal_handler_disconnect(gtkconv->entry, GPOINTER_TO_INT(l->data)); g_slist_free(ids); - gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); - gaim_conversation_set_data(conv, "notify-imhtml-signals", NULL); gaim_conversation_set_data(conv, "notify-entry-signals", NULL); } @@ -362,8 +355,6 @@ static void conv_created(GaimConversation *conv) { - gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); - /* always attach the signals, notify() will take care of conversation type * checking */ attach_signals(conv); @@ -380,7 +371,7 @@ * If the conversation was switched, then make sure we re-notify * because Gaim will have overwritten our custom window title. */ - notify(conv, FALSE); + notify(conv); #if 0 printf("conv_switched - %p - %p\n", old_conv, new_conv); @@ -406,7 +397,6 @@ gaimwin = GAIM_GTK_CONVERSATION(conv)->win; handle_urgent(gaimwin, FALSE); - gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); return; @@ -592,18 +582,21 @@ static void apply_method() { GList *convs; - GaimGtkWindow *gaimwin = NULL; for (convs = gaim_get_conversations(); convs != NULL; convs = convs->next) { - GaimConversation *conv = (GaimConversation *)convs->data; + GaimConversation *conv = NULL; + GaimGtkConversation *gtkconv = NULL; + conv = (GaimConversation *) convs->data; + gtkconv = GAIM_GTK_CONVERSATION(conv); + /* remove notifications */ unnotify(conv, FALSE); - gaimwin = GAIM_GTK_CONVERSATION(conv)->win; - if (GPOINTER_TO_INT(gaim_conversation_get_data(conv, "notify-message-count")) != 0) + if (gtkconv->unseen_count > 0) { /* reattach appropriate notifications */ - notify(conv, FALSE); + notify(conv); + } } } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <de...@us...> - 2006-08-24 17:37:36
|
Revision: 17018 Author: deryni9 Date: 2006-08-24 10:37:24 -0700 (Thu, 24 Aug 2006) ViewCVS: http://svn.sourceforge.net/gaim/?rev=17018&view=rev Log Message: ----------- Revert commit 16946 "Use the gtk conversation unseen_count instead of keeping my own count." since that unseen_count gets reset before I get a chance to remove notifications. It's a bit unfortunate since keeping my own count is annoying. Modified Paths: -------------- trunk/gtk/plugins/notify.c Modified: trunk/gtk/plugins/notify.c =================================================================== --- trunk/gtk/plugins/notify.c 2006-08-24 17:33:24 UTC (rev 17017) +++ trunk/gtk/plugins/notify.c 2006-08-24 17:37:24 UTC (rev 17018) @@ -107,7 +107,7 @@ static GaimPlugin *my_plugin = NULL; /* notification set/unset */ -static int notify(GaimConversation *conv); +static int notify(GaimConversation *conv, gboolean increment); static void notify_win(GaimGtkWindow *gaimwin); static void unnotify(GaimConversation *conv, gboolean reset); static int unnotify_cb(GtkWidget *widget, gpointer data, GaimConversation *conv); @@ -135,26 +135,28 @@ /****************************************/ /* Begin doing stuff below this line... */ /****************************************/ -static guint +static int count_messages(GaimGtkWindow *gaimwin) { - guint count = 0; - GList *gtkconvs = NULL; + gint count = 0; + GList *convs = NULL, *l; - for (gtkconvs = gaimwin->gtkconvs; gtkconvs != NULL; - gtkconvs = gtkconvs->next) { - GaimGtkConversation *gtkconv = gtkconvs->data; - count += gtkconv->unseen_count; + for (convs = gaimwin->gtkconvs; convs != NULL; convs = convs->next) { + GaimGtkConversation *conv = convs->data; + for (l = conv->convs; l != NULL; l = l->next) { + count += GPOINTER_TO_INT(gaim_conversation_get_data(l->data, "notify-message-count")); + } } return count; } static int -notify(GaimConversation *conv) +notify(GaimConversation *conv, gboolean increment) { + GaimGtkWindow *gaimwin = NULL; + gint count; gboolean has_focus; - GaimGtkWindow *gaimwin = NULL; if (conv == NULL) return 0; @@ -176,6 +178,12 @@ if (gaim_prefs_get_bool("/plugins/gtk/X11/notify/type_focused") || !has_focus) { + if (increment) { + count = GPOINTER_TO_INT(gaim_conversation_get_data(conv, "notify-message-count")); + count++; + gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(count)); + } + notify_win(gaimwin); } @@ -217,6 +225,7 @@ * just to have it readded in re-notify is an unnecessary couple extra RTs * to the server */ handle_urgent(gaimwin, FALSE); + gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); } return; @@ -225,11 +234,7 @@ static int unnotify_cb(GtkWidget *widget, gpointer data, GaimConversation *conv) { - GaimGtkConversation *gtkconv = NULL; - - gtkconv = GAIM_GTK_CONVERSATION(conv); - - if (gtkconv->unseen_count > 0) + if (GPOINTER_TO_INT(gaim_conversation_get_data(conv, "notify-message-count")) != 0) unnotify(conv, TRUE); return 0; @@ -245,7 +250,7 @@ return FALSE; if ((flags & GAIM_MESSAGE_RECV) && !(flags & GAIM_MESSAGE_DELAYED)) - notify(conv); + notify(conv, TRUE); return FALSE; } @@ -348,6 +353,8 @@ g_signal_handler_disconnect(gtkconv->entry, GPOINTER_TO_INT(l->data)); g_slist_free(ids); + gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); + gaim_conversation_set_data(conv, "notify-imhtml-signals", NULL); gaim_conversation_set_data(conv, "notify-entry-signals", NULL); } @@ -355,6 +362,8 @@ static void conv_created(GaimConversation *conv) { + gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); + /* always attach the signals, notify() will take care of conversation type * checking */ attach_signals(conv); @@ -371,7 +380,7 @@ * If the conversation was switched, then make sure we re-notify * because Gaim will have overwritten our custom window title. */ - notify(conv); + notify(conv, FALSE); #if 0 printf("conv_switched - %p - %p\n", old_conv, new_conv); @@ -397,6 +406,7 @@ gaimwin = GAIM_GTK_CONVERSATION(conv)->win; handle_urgent(gaimwin, FALSE); + gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); return; @@ -582,21 +592,18 @@ static void apply_method() { GList *convs; + GaimGtkWindow *gaimwin = NULL; for (convs = gaim_get_conversations(); convs != NULL; convs = convs->next) { - GaimConversation *conv = NULL; - GaimGtkConversation *gtkconv = NULL; + GaimConversation *conv = (GaimConversation *)convs->data; - conv = (GaimConversation *) convs->data; - gtkconv = GAIM_GTK_CONVERSATION(conv); - /* remove notifications */ unnotify(conv, FALSE); - if (gtkconv->unseen_count > 0) { + gaimwin = GAIM_GTK_CONVERSATION(conv)->win; + if (GPOINTER_TO_INT(gaim_conversation_get_data(conv, "notify-message-count")) != 0) /* reattach appropriate notifications */ - notify(conv); - } + notify(conv, FALSE); } } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <de...@us...> - 2006-08-24 20:06:15
|
Revision: 17022 Author: deryni9 Date: 2006-08-24 13:05:56 -0700 (Thu, 24 Aug 2006) ViewCVS: http://svn.sourceforge.net/gaim/?rev=17022&view=rev Log Message: ----------- Add a new notification method, this method keeps the unseen message count in an X property (_GAIM_UNSEEN_COUNT) which allow for some nifty things. Also, some whitespace, etc. nitpicks I noticed while going over this. Modified Paths: -------------- trunk/gtk/plugins/notify.c Modified: trunk/gtk/plugins/notify.c =================================================================== --- trunk/gtk/plugins/notify.c 2006-08-24 19:55:43 UTC (rev 17021) +++ trunk/gtk/plugins/notify.c 2006-08-24 20:05:56 UTC (rev 17022) @@ -105,29 +105,36 @@ #define NOTIFY_PLUGIN_ID "gtk-x11-notify" static GaimPlugin *my_plugin = NULL; +static GdkAtom _Cardinal = GDK_NONE; +static GdkAtom _GaimUnseenCount = GDK_NONE; /* notification set/unset */ static int notify(GaimConversation *conv, gboolean increment); static void notify_win(GaimGtkWindow *gaimwin); static void unnotify(GaimConversation *conv, gboolean reset); -static int unnotify_cb(GtkWidget *widget, gpointer data, GaimConversation *conv); +static int unnotify_cb(GtkWidget *widget, gpointer data, + GaimConversation *conv); /* gtk widget callbacks for prefs panel */ static void type_toggle_cb(GtkWidget *widget, gpointer data); static void method_toggle_cb(GtkWidget *widget, gpointer data); static void notify_toggle_cb(GtkWidget *widget, gpointer data); -static gboolean options_entry_cb(GtkWidget *widget, GdkEventFocus *event, gpointer data); +static gboolean options_entry_cb(GtkWidget *widget, GdkEventFocus *event, + gpointer data); static void apply_method(void); static void apply_notify(void); /* string function */ static void handle_string(GaimGtkWindow *gaimwin); -/* count function */ -static void handle_count(GaimGtkWindow *gaimwin); +/* count_title function */ +static void handle_count_title(GaimGtkWindow *gaimwin); +/* count_xprop function */ +static void handle_count_xprop(GaimGtkWindow *gaimwin); + /* urgent function */ -static void handle_urgent(GaimGtkWindow *gaimwin, gboolean add); +static void handle_urgent(GaimGtkWindow *gaimwin, gboolean set); /* raise function */ static void handle_raise(GaimGtkWindow *gaimwin); @@ -135,10 +142,10 @@ /****************************************/ /* Begin doing stuff below this line... */ /****************************************/ -static int +static guint count_messages(GaimGtkWindow *gaimwin) { - gint count = 0; + guint count = 0; GList *convs = NULL, *l; for (convs = gaimwin->gtkconvs; convs != NULL; convs = convs->next) { @@ -154,9 +161,9 @@ static int notify(GaimConversation *conv, gboolean increment) { - GaimGtkWindow *gaimwin = NULL; gint count; gboolean has_focus; + GaimGtkWindow *gaimwin = NULL; if (conv == NULL) return 0; @@ -197,7 +204,9 @@ return; if (gaim_prefs_get_bool("/plugins/gtk/X11/notify/method_count")) - handle_count(gaimwin); + handle_count_title(gaimwin); + if (gaim_prefs_get_bool("/plugins/gtk/X11/notify/method_count_xprop")) + handle_count_xprop(gaimwin); if (gaim_prefs_get_bool("/plugins/gtk/X11/notify/method_string")) handle_string(gaimwin); if (gaim_prefs_get_bool("/plugins/gtk/X11/notify/method_urgent")) @@ -221,11 +230,15 @@ gaim_conversation_autoset_title(active_conv); if (reset) { - /* Only need to actually remove the urgent hinting here, since removing it - * just to have it readded in re-notify is an unnecessary couple extra RTs - * to the server */ + /* Only need to actually remove the urgent hinting here, since + * removing it just to have it readded in re-notify is an + * unnecessary couple extra RTs to the server */ handle_urgent(gaimwin, FALSE); gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); + /* Same logic as for the urgent hint, xprops are also a RT. + * This needs to go here so that it gets the updated message + * count. */ + handle_count_xprop(gaimwin); } return; @@ -242,7 +255,7 @@ static gboolean message_displayed_cb(GaimAccount *account, const char *who, char *message, - GaimConversation *conv, GaimMessageFlags flags) + GaimConversation *conv, GaimMessageFlags flags) { if ((gaim_conversation_get_type(conv) == GAIM_CONV_TYPE_CHAT && gaim_prefs_get_bool("/plugins/gtk/X11/notify/type_chat_nick") && @@ -256,7 +269,8 @@ } static void -im_sent_im(GaimAccount *account, const char *receiver, const char *message) { +im_sent_im(GaimAccount *account, const char *receiver, const char *message) +{ GaimConversation *conv = NULL; if (gaim_prefs_get_bool("/plugins/gtk/X11/notify/notify_send")) { @@ -293,9 +307,9 @@ gtkwin = gtkconv->win; if (gaim_prefs_get_bool("/plugins/gtk/X11/notify/notify_focus")) { - /* TODO should really find a way to make this work no matter where the - * focus is inside the conv window, without having to bind to - * focus-in-event on the g(d|t)kwindow */ + /* TODO should really find a way to make this work no matter + * where the focus is inside the conv window, without having + * to bind to focus-in-event on the g(d|t)kwindow */ /* try setting the signal on the focus-in-event for * gtkwin->notebook->container? */ id = g_signal_connect(G_OBJECT(gtkconv->entry), "focus-in-event", @@ -308,8 +322,8 @@ } if (gaim_prefs_get_bool("/plugins/gtk/X11/notify/notify_click")) { - /* TODO similarly should really find a way to allow for clicking in other - * places of the window */ + /* TODO similarly should really find a way to allow for + * clicking in other places of the window */ id = g_signal_connect(G_OBJECT(gtkconv->entry), "button-press-event", G_CALLBACK(unnotify_cb), conv); entry_ids = g_slist_append(entry_ids, GUINT_TO_POINTER(id)); @@ -362,10 +376,11 @@ static void conv_created(GaimConversation *conv) { - gaim_conversation_set_data(conv, "notify-message-count", GINT_TO_POINTER(0)); + gaim_conversation_set_data(conv, "notify-message-count", + GINT_TO_POINTER(0)); - /* always attach the signals, notify() will take care of conversation type - * checking */ + /* always attach the signals, notify() will take care of conversation + * type checking */ attach_signals(conv); } @@ -484,7 +499,7 @@ } static void -handle_count(GaimGtkWindow *gaimwin) +handle_count_title(GaimGtkWindow *gaimwin) { GtkWindow *window; char newtitle[256]; @@ -500,9 +515,36 @@ } static void -handle_urgent(GaimGtkWindow *win, gboolean add) +handle_count_xprop(GaimGtkWindow *gaimwin) { #ifndef _WIN32 + guint count; + GtkWidget *window; + GdkWindow *gdkwin; + + window = gaimwin->window; + g_return_if_fail(window != NULL); + + if (_GaimUnseenCount == GDK_NONE) { + _GaimUnseenCount = gdk_atom_intern("_GAIM_UNSEEN_COUNT", FALSE); + } + + if (_Cardinal == GDK_NONE) { + _Cardinal = gdk_atom_intern("CARDINAL", FALSE); + } + + count = count_messages(gaimwin); + gdkwin = window->window; + + gdk_property_change(gdkwin, _GaimUnseenCount, _Cardinal, 32, + GDK_PROP_MODE_REPLACE, (guchar *) &count, 1); +#endif +} + +static void +handle_urgent(GaimGtkWindow *win, gboolean set) +{ +#ifndef _WIN32 XWMHints *hints; g_return_if_fail(win != NULL); @@ -514,7 +556,7 @@ if(!hints) hints = XAllocWMHints(); - if (add) + if (set) hints->flags |= XUrgencyHint; else hints->flags &= ~XUrgencyHint; @@ -536,7 +578,8 @@ gboolean on = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget)); gchar pref[256]; - g_snprintf(pref, sizeof(pref), "/plugins/gtk/X11/notify/%s", (char *)data); + g_snprintf(pref, sizeof(pref), "/plugins/gtk/X11/notify/%s", + (char *)data); gaim_prefs_set_bool(pref, on); } @@ -547,7 +590,8 @@ gboolean on = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget)); gchar pref[256]; - g_snprintf(pref, sizeof(pref), "/plugins/gtk/X11/notify/%s", (char *)data); + g_snprintf(pref, sizeof(pref), "/plugins/gtk/X11/notify/%s", + (char *)data); gaim_prefs_set_bool(pref, on); @@ -567,7 +611,8 @@ gboolean on = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget)); gchar pref[256]; - g_snprintf(pref, sizeof(pref), "/plugins/gtk/X11/notify/%s", (char *)data); + g_snprintf(pref, sizeof(pref), "/plugins/gtk/X11/notify/%s", + (char *)data); gaim_prefs_set_bool(pref, on); @@ -581,7 +626,8 @@ return FALSE; if (!strcmp(data, "method_string")) { - gaim_prefs_set_string("/plugins/gtk/X11/notify/title_string", gtk_entry_get_text(GTK_ENTRY(widget))); + gaim_prefs_set_string("/plugins/gtk/X11/notify/title_string", + gtk_entry_get_text(GTK_ENTRY(widget))); } apply_method(); @@ -590,11 +636,13 @@ } static void -apply_method() { +apply_method() +{ GList *convs; GaimGtkWindow *gaimwin = NULL; - for (convs = gaim_get_conversations(); convs != NULL; convs = convs->next) { + for (convs = gaim_get_conversations(); convs != NULL; + convs = convs->next) { GaimConversation *conv = (GaimConversation *)convs->data; /* remove notifications */ @@ -706,6 +754,14 @@ G_CALLBACK(method_toggle_cb), "method_count"); #ifndef _WIN32 + /* Count xprop method button */ + toggle = gtk_check_button_new_with_mnemonic(_("Insert count of new message into _X property")); + gtk_box_pack_start(GTK_BOX(vbox), toggle, FALSE, FALSE, 0); + gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(toggle), + gaim_prefs_get_bool("/plugins/gtk/X11/notify/method_count_xprop")); + g_signal_connect(G_OBJECT(toggle), "toggled", + G_CALLBACK(method_toggle_cb), "method_count_xprop"); + /* Urgent method button */ toggle = gtk_check_button_new_with_mnemonic(_("Set window manager \"_URGENT\" hint")); gtk_box_pack_start(GTK_BOX(vbox), toggle, FALSE, FALSE, 0); @@ -856,8 +912,8 @@ N_("Provides a variety of ways of notifying you of unread messages."), /** description */ N_("Provides a variety of ways of notifying you of unread messages."), + /**< author */ "Etan Reisner <de...@ed...>\n\t\t\tBrian Tarricone <bj...@co...>", - /**< author */ GAIM_WEBSITE, /**< homepage */ plugin_load, /**< load */ @@ -885,6 +941,7 @@ gaim_prefs_add_string("/plugins/gtk/X11/notify/title_string", "(*)"); gaim_prefs_add_bool("/plugins/gtk/X11/notify/method_urgent", FALSE); gaim_prefs_add_bool("/plugins/gtk/X11/notify/method_count", FALSE); + gaim_prefs_add_bool("/plugins/gtk/X11/notify/method_count_xprop", FALSE); gaim_prefs_add_bool("/plugins/gtk/X11/notify/method_raise", FALSE); gaim_prefs_add_bool("/plugins/gtk/X11/notify/notify_focus", FALSE); gaim_prefs_add_bool("/plugins/gtk/X11/notify/notify_click", FALSE); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <de...@us...> - 2006-08-31 03:12:13
|
Revision: 17092 http://svn.sourceforge.net/gaim/?rev=17092&view=rev Author: deryni9 Date: 2006-08-30 20:12:07 -0700 (Wed, 30 Aug 2006) Log Message: ----------- A long line fix, this is just so it doesn't get in my way in a minute. Modified Paths: -------------- trunk/gtk/plugins/notify.c Modified: trunk/gtk/plugins/notify.c =================================================================== --- trunk/gtk/plugins/notify.c 2006-08-31 02:59:59 UTC (rev 17091) +++ trunk/gtk/plugins/notify.c 2006-08-31 03:12:07 UTC (rev 17092) @@ -599,7 +599,8 @@ GtkWidget *entry = g_object_get_data(G_OBJECT(widget), "title-entry"); gtk_widget_set_sensitive(entry, on); - gaim_prefs_set_string("/plugins/gtk/X11/notify/title_string", gtk_entry_get_text(GTK_ENTRY(entry))); + gaim_prefs_set_string("/plugins/gtk/X11/notify/title_string", + gtk_entry_get_text(GTK_ENTRY(entry))); } apply_method(); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <de...@us...> - 2006-10-12 13:42:18
|
Revision: 17470 http://svn.sourceforge.net/gaim/?rev=17470&view=rev Author: deryni9 Date: 2006-10-12 06:42:11 -0700 (Thu, 12 Oct 2006) Log Message: ----------- Apparently a bunch of Ubuntu users weren't bothering to look at the configuration options for this plugin and were filing bugs about the window continuing to flash after being clicked on. This should help fix that. Modified Paths: -------------- trunk/gtk/plugins/notify.c Modified: trunk/gtk/plugins/notify.c =================================================================== --- trunk/gtk/plugins/notify.c 2006-10-12 05:29:08 UTC (rev 17469) +++ trunk/gtk/plugins/notify.c 2006-10-12 13:42:11 UTC (rev 17470) @@ -944,7 +944,7 @@ gaim_prefs_add_bool("/plugins/gtk/X11/notify/method_count", FALSE); gaim_prefs_add_bool("/plugins/gtk/X11/notify/method_count_xprop", FALSE); gaim_prefs_add_bool("/plugins/gtk/X11/notify/method_raise", FALSE); - gaim_prefs_add_bool("/plugins/gtk/X11/notify/notify_focus", FALSE); + gaim_prefs_add_bool("/plugins/gtk/X11/notify/notify_focus", TRUE); gaim_prefs_add_bool("/plugins/gtk/X11/notify/notify_click", FALSE); gaim_prefs_add_bool("/plugins/gtk/X11/notify/notify_type", TRUE); gaim_prefs_add_bool("/plugins/gtk/X11/notify/notify_send", TRUE); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |