pidgin-commits

[Gaim-commits] SF.net SVN: gaim: [16656] trunk/src/protocols/qq/qq_proxy.c

[<mar...@us...>]

Revision: 16656
Author:   markhuetsch
Date:     2006-08-06 11:19:36 -0700 (Sun, 06 Aug 2006)
ViewCVS:  http://svn.sourceforge.net/gaim/?rev=16656&view=rev

Log Message:
-----------
Fixed a buffer overflow that occurred when showing large packets.

Modified Paths:
--------------
    trunk/src/protocols/qq/qq_proxy.c
Modified: trunk/src/protocols/qq/qq_proxy.c
===================================================================
--- trunk/src/protocols/qq/qq_proxy.c	2006-08-06 17:41:51 UTC (rev 16655)
+++ trunk/src/protocols/qq/qq_proxy.c	2006-08-06 18:19:36 UTC (rev 16656)
@@ -56,7 +56,7 @@
 
 void _qq_show_packet(gchar *desc, gchar *buf, gint len)
 {
-	char buf1[4096], buf2[10];
+	char buf1[8*len+2], buf2[10];
 	int i;
 	buf1[0] = 0;
 	for (i = 0; i < len; i++) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Gaim-commits] SF.net SVN: gaim: [16748] trunk/src/protocols/qq/qq_proxy.c

[<the...@us...>]

Revision: 16748
Author:   thekingant
Date:     2006-08-14 00:23:11 -0700 (Mon, 14 Aug 2006)
ViewCVS:  http://svn.sourceforge.net/gaim/?rev=16748&view=rev

Log Message:
-----------
I really don't feel like changing qq right now

Modified Paths:
--------------
    trunk/src/protocols/qq/qq_proxy.c
Modified: trunk/src/protocols/qq/qq_proxy.c
===================================================================
--- trunk/src/protocols/qq/qq_proxy.c	2006-08-14 07:18:58 UTC (rev 16747)
+++ trunk/src/protocols/qq/qq_proxy.c	2006-08-14 07:23:11 UTC (rev 16748)
@@ -119,7 +119,7 @@
 
 /* the callback function after socket is built
  * we setup the qq protocol related configuration here */
-static void _qq_got_login(gpointer data, gint source)
+static void _qq_got_login(gpointer data, gint source, const gchar *error_message)
 {
 	qq_data *qd;
 	GaimConnection *gc;
@@ -127,13 +127,14 @@
 	const gchar *passwd;
 
 	gc = (GaimConnection *) data;
-	g_return_if_fail(gc != NULL && gc->proto_data != NULL);
 
-	if (g_list_find(gaim_connections_get_all(), gc) == NULL) {
+	if (!GAIM_CONNECTION_IS_VALID(gc)) {
 		close(source);
 		return;
 	}
 
+	g_return_if_fail(gc != NULL && gc->proto_data != NULL);
+
 	if (source < 0) {	/* socket returns -1 */
 		gaim_connection_error(gc, _("Unable to connect."));
 		return;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.