pidgin-commits

[Gaim-commits] SF.net SVN: gaim: [16071] trunk/src/plugin.c

[<rl...@us...>]

Revision: 16071
Author:   rlaager
Date:     2006-04-19 22:19:12 -0700 (Wed, 19 Apr 2006)
ViewCVS:  http://svn.sourceforge.net/gaim/?rev=16071&view=rev

Log Message:
-----------
CID 102:
Description: Variable "basename" tracked as NULL was passed to a function that dereferences it.

Modified Paths:
--------------
    trunk/src/plugin.c
Modified: trunk/src/plugin.c
===================================================================
--- trunk/src/plugin.c	2006-04-20 05:12:22 UTC (rev 16070)
+++ trunk/src/plugin.c	2006-04-20 05:19:12 UTC (rev 16071)
@@ -1223,7 +1223,7 @@
 
 		/* Strip the extension */
 		if (basename)
-			basename = gaim_plugin_get_basename(basename);
+			basename = gaim_plugin_get_basename(filename);
 
 		if ((plugin = gaim_plugins_find_with_filename(filename)) != NULL)
 		{


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Gaim-commits] SF.net SVN: gaim: [16697] trunk/src/plugin.c

[<dat...@us...>]

Revision: 16697
Author:   datallah
Date:     2006-08-10 19:02:53 -0700 (Thu, 10 Aug 2006)
ViewCVS:  http://svn.sourceforge.net/gaim/?rev=16697&view=rev

Log Message:
-----------
CID 102  - This would probably take someone messing with prefs.xml manually to be encountered (I don't think there is any way to load plugins with relative paths, but I suppose with libgaim someone might try to do it).

Modified Paths:
--------------
    trunk/src/plugin.c
Modified: trunk/src/plugin.c
===================================================================
--- trunk/src/plugin.c	2006-08-11 01:30:22 UTC (rev 16696)
+++ trunk/src/plugin.c	2006-08-11 02:02:53 UTC (rev 16697)
@@ -1232,7 +1232,7 @@
 							plugin->path);
 			gaim_plugin_load(plugin);
 		}
-		else if ((plugin = gaim_plugins_find_with_basename(basename)) != NULL)
+		else if (basename && (plugin = gaim_plugins_find_with_basename(basename)) != NULL)
 		{
 			gaim_debug_info("plugins", "Loading saved plugin %s\n",
 							plugin->path);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.