From: Tim R. <ma...@us...> - 2005-03-17 11:13:57
|
Update of /cvsroot/gaim/gaim/src/protocols/yahoo In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26092/src/protocols/yahoo Modified Files: Tag: oldstatus yahoo.c Log Message: bleeter fixed a bug in his privacy patch Index: yahoo.c =================================================================== RCS file: /cvsroot/gaim/gaim/src/protocols/yahoo/yahoo.c,v retrieving revision 1.273.2.15 retrieving revision 1.273.2.16 diff -u -d -p -r1.273.2.15 -r1.273.2.16 --- yahoo.c 17 Mar 2005 05:17:05 -0000 1.273.2.15 +++ yahoo.c 17 Mar 2005 11:13:45 -0000 1.273.2.16 @@ -70,14 +70,18 @@ yahoo_rem_permit(GaimConnection *gc, con gaim_privacy_permit_remove(gc->account,who,TRUE); } -gboolean yahoo_check_privacy - (GaimConnection *gc, const char *who) +gboolean yahoo_check_privacy(GaimConnection *gc, const char *who) { /* returns TRUE if allowed through, FALSE otherwise */ GSList *list; gboolean permitted=FALSE; - switch ( gc->account->perm_deny ) { + switch (gc->account->perm_deny) { + /* it would appear somewhere inside gaim, GAIM_PRIVACY can end up + * being set to 0 */ + case 0: + permitted = TRUE; + break; case GAIM_PRIVACY_ALLOW_ALL: permitted = TRUE; break; |
From: Vijaykumar P. <vij...@wi...> - 2005-03-18 09:57:09
|
Hi Tim, A small point, though may not be a significant issue :). >- switch ( gc->account->perm_deny ) { >+ switch (gc->account->perm_deny) { >+ /* it would appear somewhere inside gaim, GAIM_PRIVACY can end up >+ * being set to 0 */ >+ case 0: > > We could get GaimPrivacyType emun to have GAIM_PRIVACY_NONE as the first one hence avoiding the combination of actual numericals and enumerations in switch case. >+ permitted = TRUE; >+ break; > > It was a good patch indeed :). Regards Vijay. |
From: Mark D. <ma...@ki...> - 2005-03-20 01:54:01
|
On Fri, 18 Mar 2005 15:19:23 +0530, Vijaykumar Patwari wrote > Hi Tim, > > A small point, though may not be a significant issue :). > > >- switch ( gc->account->perm_deny ) { > >+ switch (gc->account->perm_deny) { > >+ /* it would appear somewhere inside gaim, GAIM_PRIVACY can end up > >+ * being set to 0 */ > >+ case 0: > > > > > We could get GaimPrivacyType emun to have GAIM_PRIVACY_NONE as the > first one hence avoiding the combination of actual numericals and > enumerations in switch case. > > >+ permitted = TRUE; > >+ break; > > > > > It was a good patch indeed :). > > Regards > Vijay. As discussed in #gaim a few minutes ago, I'm against adding a GAIM_PRIVACY_NONE because it logically doesn't make any sense. Even if a protocol did not have any concept of privacy, the privacy setting should be GAIM_PRIVACY_ALLOW_ALL. The perm_deny setting should never be 0... adding a #define for the case when it IS 0 only legitimizes something that is a bug and needs to be fixed elsewhere. -Mark |